Fix method ambiguities and limit operate to Number subtypes #2224

odow · 2023-06-24T00:33:42Z

solver-tests: https://github.com/jump-dev/MathOptInterface.jl/actions/runs/5361630981

blegat · 2023-06-24T08:53:56Z

Maybe we could add tests actually

odow · 2023-06-24T09:46:30Z

What we really need to do is fix:

julia> Test.detect_ambiguities(MOI; recursive = true)
41-element Vector{Tuple{Method, Method}}:
[...]

odow · 2023-06-24T10:02:18Z

There are lots of these that are pedantic. Like

a = dot(α::T, func::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1760
b = dot(::ChainRulesCore.NoTangent, ::Any) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_arithmetic.jl:67

would only happen for MathOptInterface.ScalarAffineFunction{ChainRulesCore.NoTangent}.

They mostly stem from cases where T is not <:Number. We should really rethink the weak assumption there.

julia> for (a, b) in Test.detect_ambiguities(MOI; recursive = true)
           @show a
           @show b
           println()
       end
a = *(f::T, g::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1678
b = *(z::MutableArithmetics.Zero, ::Any) in MutableArithmetics at /Users/oscar/.julia/packages/MutableArithmetics/geMUn/src/rewrite.jl:53

a = operate(::typeof(+), ::Type{T}, f::MathOptInterface.ScalarAffineFunction{T}, g::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, T}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:127
b = operate(::typeof(+), ::Type{T}, f::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarNonlinearFunction, MathOptInterface.ScalarQuadraticFunction{T}, T}, g::MathOptInterface.ScalarNonlinearFunction) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:174

a = *(f::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}} where T, g::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}} where T, args::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}} where T...) in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1572
b = *(f::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}, g::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1666

a = *(f::T, g::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1678
b = *(::ChainRulesCore.ZeroTangent, ::Any) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_arithmetic.jl:104

a = *(f::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}, g::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1666
b = *(::Any, ::ChainRulesCore.NoTangent) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_arithmetic.jl:65

a = get(model::MathOptInterface.ModelLike, attr::MathOptInterface.AbstractConstraintAttribute, bridge::MathOptInterface.Bridges.Constraint.AbstractFunctionConversionBridge) in MathOptInterface.Bridges.Constraint at /Users/oscar/.julia/dev/MathOptInterface/src/Bridges/Constraint/bridges/functionize.jl:17
b = get(model::MathOptInterface.ModelLike, ::MathOptInterface.CanonicalConstraintFunction, bridge::MathOptInterface.Bridges.AbstractBridge) in MathOptInterface.Bridges at /Users/oscar/.julia/dev/MathOptInterface/src/Bridges/bridge.jl:151

a = operate(::typeof(*), ::Type{T}, f::T, g::MathOptInterface.ScalarNonlinearFunction) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:566
b = operate(::typeof(*), ::Type{T}, f::MathOptInterface.ScalarNonlinearFunction, g::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:593

a = operate(::typeof(*), ::Type{T}, f::T, g::MathOptInterface.VectorOfVariables) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:541
b = operate(::typeof(*), ::Type{T}, f::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorOfVariables, MathOptInterface.VectorQuadraticFunction{T}}, g::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:577

a = /(f::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}, g::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1717
b = /(::Any, x::ChainRulesCore.NotImplemented) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_types/notimplemented.jl:43

a = promote_operation(::typeof(*), ::Type{T}, ::Type{T}, ::Type{MathOptInterface.VectorOfVariables}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/promote_operation.jl:214
b = promote_operation(::typeof(*), ::Type{T}, ::Type{MathOptInterface.VectorOfVariables}, ::Type{T}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/promote_operation.jl:254

a = dot(f::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}} where T, g::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}} where T) in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1759
b = dot(α::T, func::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1760

a = dot(func::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}, α::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1761
b = dot(::Any, ::ChainRulesCore.NoTangent) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_arithmetic.jl:68

a = get(bridge::MathOptInterface.Bridges.Constraint._AbstractSlackBridge{T, VF, ZS, F, S} where S, ::MathOptInterface.ListOfConstraintIndices{F, ZS}) where {T, VF, ZS, F} in MathOptInterface.Bridges.Constraint at /Users/oscar/.julia/dev/MathOptInterface/src/Bridges/Constraint/bridges/slack.jl:35
b = get(bridge::MathOptInterface.Bridges.Constraint._AbstractSlackBridge{T, VF, ZS, F, S}, ::MathOptInterface.ListOfConstraintIndices{VF, S}) where {T, VF, ZS, F, S} in MathOptInterface.Bridges.Constraint at /Users/oscar/.julia/dev/MathOptInterface/src/Bridges/Constraint/bridges/slack.jl:42

a = promote_operation(::typeof(*), ::Type{T}, ::Type{T}, ::Type{MathOptInterface.VariableIndex}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/promote_operation.jl:205
b = promote_operation(::typeof(*), ::Type{T}, ::Type{MathOptInterface.VariableIndex}, ::Type{T}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/promote_operation.jl:245

a = operate(::typeof(+), ::Type{T}, f::MathOptInterface.VariableIndex, g::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:102
b = operate(::typeof(+), ::Type{T}, f::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarNonlinearFunction, MathOptInterface.ScalarQuadraticFunction{T}, T}, g::MathOptInterface.ScalarNonlinearFunction) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:174

a = dot(f::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}} where T, g::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}} where T) in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1759
b = dot(func::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}, α::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1761

a = _add_sub_affine_terms(op::Union{typeof(+), typeof(-)}, terms::Array{MathOptInterface.ScalarAffineTerm{T}, 1}, α::T, f::MathOptInterface.VariableIndex, β::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/mutable_arithmetics.jl:267
b = _add_sub_affine_terms(op::Union{typeof(+), typeof(-)}, terms::Array{MathOptInterface.ScalarAffineTerm{T}, 1}, α::T, β::T, args::Vararg{Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, T} where T, N}) where {T, N} in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/mutable_arithmetics.jl:361

a = dot(func::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}, α::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1761
b = dot(::Any, x::ChainRulesCore.NotImplemented) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_arithmetic.jl:40

a = dot(α::T, func::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1760
b = dot(::ChainRulesCore.ZeroTangent, ::Any) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_arithmetic.jl:107

a = _add_sub_affine_terms(op::Union{typeof(+), typeof(-)}, terms::Array{MathOptInterface.ScalarAffineTerm{T}, 1}, f::MathOptInterface.VariableIndex, β::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/mutable_arithmetics.jl:278
b = _add_sub_affine_terms(op::Union{typeof(+), typeof(-)}, terms::Array{MathOptInterface.ScalarAffineTerm{T}, 1}, α::T, f::MathOptInterface.VariableIndex) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/mutable_arithmetics.jl:288

a = dot(α::T, func::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1760
b = dot(::ChainRulesCore.NoTangent, ::Any) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_arithmetic.jl:67

a = operate(::typeof(-), ::Type{T}, f::MathOptInterface.ScalarAffineFunction{T}, g::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, T}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:372
b = operate(::typeof(-), ::Type{T}, f::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarNonlinearFunction, MathOptInterface.ScalarQuadraticFunction{T}, T}, g::MathOptInterface.ScalarNonlinearFunction) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:423

a = promote_rule(F::Type{MathOptInterface.ScalarQuadraticFunction{T}}, ::Type{T}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:2274
b = promote_rule(F::Type{var"#s288"} where var"#s288"<:Union{MathOptInterface.ScalarAffineFunction, MathOptInterface.ScalarQuadraticFunction}, ::Type{MathOptInterface.VariableIndex}) in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:2281

a = *(f::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}, g::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1666
b = *(::Any, ::ChainRulesCore.ZeroTangent) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_arithmetic.jl:105

a = *(f::T, g::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1678
b = *(::ChainRulesCore.NoTangent, ::Any) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_arithmetic.jl:64

a = promote_rule(F::Type{MathOptInterface.ScalarAffineFunction{T}}, ::Type{T}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:2267
b = promote_rule(F::Type{var"#s288"} where var"#s288"<:Union{MathOptInterface.ScalarAffineFunction, MathOptInterface.ScalarQuadraticFunction}, ::Type{MathOptInterface.VariableIndex}) in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:2281

a = *(f::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}, g::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1666
b = *(::Any, x::ChainRulesCore.NotImplemented) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_arithmetic.jl:38

a = *(f::T, g::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1678
b = *(x::ChainRulesCore.NotImplemented, ::Any) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_arithmetic.jl:37

a = get(::MathOptInterface.Bridges.Constraint._AbstractSlackBridge{T, VF, ZS, F, S} where S, ::MathOptInterface.NumberOfConstraints{F, ZS}) where {T, VF, ZS, F} in MathOptInterface.Bridges.Constraint at /Users/oscar/.julia/dev/MathOptInterface/src/Bridges/Constraint/bridges/slack.jl:21
b = get(::MathOptInterface.Bridges.Constraint._AbstractSlackBridge{T, VF, ZS, F, S}, ::MathOptInterface.NumberOfConstraints{VF, S}) where {T, VF, ZS, F, S} in MathOptInterface.Bridges.Constraint at /Users/oscar/.julia/dev/MathOptInterface/src/Bridges/Constraint/bridges/slack.jl:28

a = operate(::typeof(-), ::Type{T}, f::MathOptInterface.ScalarQuadraticFunction{T}, g::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, T}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:394
b = operate(::typeof(-), ::Type{T}, f::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarNonlinearFunction, MathOptInterface.ScalarQuadraticFunction{T}, T}, g::MathOptInterface.ScalarNonlinearFunction) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:423

a = *(f::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}} where T, g::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}} where T, args::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}} where T...) in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1572
b = *(f::T, g::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1678

a = operate(::typeof(+), ::Type{T}, f::MathOptInterface.ScalarQuadraticFunction{T}, g::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, T}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:145
b = operate(::typeof(+), ::Type{T}, f::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarNonlinearFunction, MathOptInterface.ScalarQuadraticFunction{T}, T}, g::MathOptInterface.ScalarNonlinearFunction) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:174

a = dot(func::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}, α::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1761
b = dot(::Any, ::ChainRulesCore.ZeroTangent) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_arithmetic.jl:108

a = dot(α::T, func::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}, MathOptInterface.VectorAffineFunction{T}, MathOptInterface.VectorQuadraticFunction{T}}) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/functions.jl:1760
b = dot(x::ChainRulesCore.NotImplemented, ::Any) in ChainRulesCore at /Users/oscar/.julia/packages/ChainRulesCore/a4mIA/src/tangent_arithmetic.jl:39

a = operate(::typeof(-), ::Type{T}, f::MathOptInterface.VariableIndex, g::T) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:347
b = operate(::typeof(-), ::Type{T}, f::Union{MathOptInterface.VariableIndex, MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarNonlinearFunction, MathOptInterface.ScalarQuadraticFunction{T}, T}, g::MathOptInterface.ScalarNonlinearFunction) where T in MathOptInterface.Utilities at /Users/oscar/.julia/dev/MathOptInterface/src/Utilities/operate.jl:423

blegat · 2023-06-24T10:22:22Z

I think it's find to assume T<:Number

odow · 2023-06-25T23:06:00Z

https://github.com/jump-dev/MathOptInterface.jl/actions/runs/5372235809

src/Bridges/Constraint/bridges/slack.jl

odow · 2023-06-25T23:08:33Z

src/Utilities/functions.jl

-    },
-) where {T}
-    return g * f
-end


This is breaking, but only in the sense that it was never documented or expected to work. having functions with non-number coefficients is just asking for trouble.

It's also weird because this is the only case where we'd expect things to work. You can't do *(::NonNumber, ::VariableIndex)

odow · 2023-06-25T23:08:57Z

src/Utilities/functions.jl

@@ -1697,7 +1669,7 @@ function Base.:/(
        MOI.VectorQuadraticFunction{T},
    },
    g::T,
-) where {T}
+) where {T<:Number}


Ditto here. The method below assumes Number, so these are really inconsistent and a bug fix.

odow · 2023-06-25T23:09:29Z

src/Utilities/universalfallback.jl

@@ -641,7 +641,7 @@ function check_type_and_multiple_names(
    value::T,
    ::Nothing,
    name,
-) where {T}
+) where {T<:MOI.Index}


This is non-breaking and just a pure fix.

odow · 2023-06-26T01:28:04Z

I think I'm okay marking this as a bug-fix. We certainly never intended for MOI to work with non-number coefficients, and only a very small subset of methods would currently work.

src/Bridges/Constraint/bridges/functionize.jl

odow · 2023-06-27T23:42:39Z

Updated solver-tests, now with JuMP extensions: https://github.com/jump-dev/MathOptInterface.jl/actions/runs/5395649560

odow · 2023-06-28T02:06:15Z

@blegat I guess we should hold off on this until SumOfSquares and PolyJuMP are installable and passing tests?

odow · 2023-07-02T08:07:55Z

https://github.com/jump-dev/MathOptInterface.jl/actions/runs/5435499633

odow · 2023-07-02T20:43:30Z

@blegat solver-tests looks good on this PR, so I think we're okay to merge?

blegat · 2023-07-04T16:40:23Z

Yes, we can merge

chriscoey · 2023-07-10T20:47:55Z

@odow I'd like to be able to replace the following logic (where f is often an SNF):

function canonicalize_SNF(::Type{T}, f) where {T <: Real}
    try
        f = convert(MOI.ScalarQuadraticFunction{T}, f)
        try
            f = convert(MOI.ScalarAffineFunction{T}, f)
        catch end
    catch end
    return f
end

with a single "canonicalize" call, like e.g. f = canonicalize(T, f), or something like that. Is that doable?

odow · 2023-08-01T22:19:09Z

Rebased and re-ran solver-tests: https://github.com/jump-dev/MathOptInterface.jl/actions/runs/5732403691

odow · 2023-08-01T22:20:01Z

@chriscoey let's talk about this separately. You'd probably need to write something like that in your own package. I don't know if we want it in MOI.

odow · 2023-08-02T00:00:59Z

All solver-tests passing, so I think we're good to go. I'll wait for @blegat to take another look, since it has been a while.

blegat approved these changes Jun 24, 2023

View reviewed changes

odow commented Jun 25, 2023

View reviewed changes

src/Bridges/Constraint/bridges/slack.jl Show resolved Hide resolved

odow commented Jun 25, 2023

View reviewed changes

odow changed the title ~~[Utilities] fix ambiguity with MutableArithmetics~~ Fix method ambiguities and limit operate to Number subtypes Jun 26, 2023

blegat reviewed Jun 26, 2023

View reviewed changes

src/Bridges/Constraint/bridges/functionize.jl Outdated Show resolved Hide resolved

blegat reviewed Jun 27, 2023

View reviewed changes

src/Bridges/Constraint/bridges/functionize.jl Show resolved Hide resolved

odow force-pushed the od/fix-ambiguity branch from 1c117c5 to 5411c9f Compare June 27, 2023 23:41

odow mentioned this pull request Jun 29, 2023

[Bridges] add ScalarQuadraticToScalarNonlinearBridge #2233

Merged

14 tasks

odow force-pushed the od/fix-ambiguity branch from 5411c9f to c61a2df Compare June 29, 2023 23:35

odow mentioned this pull request Jul 2, 2023

Prep for v1.19.0 #2232

Merged

3 tasks

odow added 6 commits August 2, 2023 10:18

[Utilities] fix ambiguity with MutableArithmetics

47f4100

Remove ambiguities

b12241b

Remove non-number multiplication

b31f65f

Update

a90cd6e

Updates

b36a994

Update

4396c93

odow added 2 commits August 2, 2023 10:18

Fix functionize method

2f60715

Updates

049a92f

odow force-pushed the od/fix-ambiguity branch from c61a2df to 049a92f Compare August 1, 2023 22:18

blegat approved these changes Aug 2, 2023

View reviewed changes

odow merged commit b1f7515 into master Aug 2, 2023
47 of 50 checks passed

odow deleted the od/fix-ambiguity branch August 2, 2023 20:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix method ambiguities and limit operate to Number subtypes #2224

Fix method ambiguities and limit operate to Number subtypes #2224

odow commented Jun 24, 2023 •

edited

Loading

blegat commented Jun 24, 2023

odow commented Jun 24, 2023 •

edited

Loading

odow commented Jun 24, 2023

blegat commented Jun 24, 2023

odow commented Jun 25, 2023

odow Jun 25, 2023

odow Jun 25, 2023

odow Jun 25, 2023

odow commented Jun 26, 2023

odow commented Jun 27, 2023

odow commented Jun 28, 2023

odow commented Jul 2, 2023

odow commented Jul 2, 2023

blegat commented Jul 4, 2023

chriscoey commented Jul 10, 2023

odow commented Aug 1, 2023

odow commented Aug 1, 2023

odow commented Aug 2, 2023

Fix method ambiguities and limit operate to Number subtypes #2224

Fix method ambiguities and limit operate to Number subtypes #2224

Conversation

odow commented Jun 24, 2023 • edited Loading

blegat commented Jun 24, 2023

odow commented Jun 24, 2023 • edited Loading

odow commented Jun 24, 2023

blegat commented Jun 24, 2023

odow commented Jun 25, 2023

odow Jun 25, 2023

Choose a reason for hiding this comment

odow Jun 25, 2023

Choose a reason for hiding this comment

odow Jun 25, 2023

Choose a reason for hiding this comment

odow commented Jun 26, 2023

odow commented Jun 27, 2023

odow commented Jun 28, 2023

odow commented Jul 2, 2023

odow commented Jul 2, 2023

blegat commented Jul 4, 2023

chriscoey commented Jul 10, 2023

odow commented Aug 1, 2023

odow commented Aug 1, 2023

odow commented Aug 2, 2023

odow commented Jun 24, 2023 •

edited

Loading

odow commented Jun 24, 2023 •

edited

Loading