Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add substitute #2250

Closed
wants to merge 1 commit into from
Closed

Add substitute #2250

wants to merge 1 commit into from

Conversation

blegat
Copy link
Member

@blegat blegat commented Aug 9, 2023

@blegat blegat marked this pull request as ready for review August 9, 2023 19:01
@blegat blegat mentioned this pull request Aug 9, 2023
Merged
@odow
Copy link
Member

odow commented Aug 10, 2023

I'm not in favor of this. It just adds yet another method. We already have too many

@odow
Copy link
Member

odow commented Aug 10, 2023

See updated #2201. I don't think we need this

@blegat
Copy link
Member Author

blegat commented Aug 11, 2023

Yes, I think we should rather change the existing one with was a bad design but that's an MOI v2 thing

@blegat blegat mentioned this pull request Aug 11, 2023
Open
@blegat blegat closed this Aug 11, 2023
@odow odow deleted the bl/substitute branch September 27, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blegat @odow