Add MOI wrapper #150
Merged
Add MOI wrapper #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlubin
reviewed
Sep 28, 2020
src/MOI_wrapper.jl
Outdated
| end | ||
| end | ||
|
|
||
| function hessian_lagrangian_structure(model::Optimizer) |
There was a problem hiding this comment.
IIRC NLopt doesn't take hessians, so all of this code can be deleted.
There was a problem hiding this comment.
Indeed, this is now removed.
src/MOI_wrapper.jl
Outdated
| end | ||
| end | ||
|
|
||
| function jacobian_structure(model::Optimizer) |
There was a problem hiding this comment.
Is this needed? NLopt supports only dense jacobians.
There was a problem hiding this comment.
Yes, I followed the approach of the MPB wrapper: since MOI gives the jacobian as the nonzero values of the fixed sparsity structure of the jacobian, the indices of this sparsity need to be queried in order to know where these nonzero values should be put in the dense jacobian given by NLopt.
|
Should be ready to merge :) |
|
Great work! Could you also update the discussion of MPB in the README? |
|
Any objection to merge ? |
|
Go for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely inspired from the Ipopt wrapper.
Closes #130