Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSDP segfault #131

Merged
merged 3 commits into from
Oct 23, 2019
Merged

Fix CSDP segfault #131

merged 3 commits into from
Oct 23, 2019

Conversation

blegat
Copy link
Member

@blegat blegat commented Oct 21, 2019

Reenable tests failing because of the CSDP segfaults: jump-dev/CSDP.jl#39 as it was fixed in jump-dev/CSDP.jl#48

@coveralls
Copy link

coveralls commented Oct 21, 2019

Coverage Status

Coverage increased (+1.5%) to 77.27% when pulling 9f7af06 on bl/csdp_segfault into 9c422ee on bl/solver_tests.

@codecov-io
Copy link

codecov-io commented Oct 22, 2019

Codecov Report

Merging #131 into bl/solver_tests will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           bl/solver_tests     #131      +/-   ##
===================================================
- Coverage            79.26%   79.05%   -0.22%     
===================================================
  Files                   27       27              
  Lines                  656      654       -2     
===================================================
- Hits                   520      517       -3     
- Misses                 136      137       +1
Impacted Files Coverage Δ
src/gram_matrix.jl 83.92% <0%> (-1.79%) ⬇️
src/Certificate.jl 80% <0%> (-0.96%) ⬇️
src/newton_polytope.jl 96.55% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c422ee...9f7af06. Read the comment docs.

@blegat blegat merged commit 11c86b7 into bl/solver_tests Oct 23, 2019
@blegat blegat deleted the bl/csdp_segfault branch May 28, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants