-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SymbolicWedderburn v0.3 -> v0.4 #341
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 85.10% 85.32% +0.22%
==========================================
Files 41 41
Lines 2222 2222
==========================================
+ Hits 1891 1896 +5
+ Misses 331 326 -5 ☔ View full report in Codecov by Sentry. |
@blegat how to turn |
also something is rather odd here: basis = SumOfSquares.Certificate.gram_basis(cert.certificate, poly)
@info eltype(basis) shows |
Maybe we could define julia> basis = MonomialBasis(monomials([x, y], 2))
MonomialBasis([y², xy, x²])
julia> generators(basis)
3-element MonomialVector{DynamicPolynomials.Commutative{DynamicPolynomials.CreationOrder}, Graded{LexOrder}}:
y²
xy
x²
julia> generators(basis) isa AbstractVector
true
julia> eltype(generators(basis))
Monomial{DynamicPolynomials.Commutative{DynamicPolynomials.CreationOrder}, Graded{LexOrder}} You could also let me know the API you need the basis to implement and we could make sure |
at the moment it's enough for basis to get an honest vector that's it. We'll overhaul the whole thing in the near future, so there's no need to define the API for the old version, right? |
No, no need, this PR can sit here and wait for StarAlgebras |
I bumped in #355 even if it's not working but I'll wait for kalmarek/SymbolicWedderburn.jl#79 |
Closes #352