Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preview bin directory for git bash #1009

Closed
wants to merge 2 commits into from
Closed

Fix preview bin directory for git bash #1009

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adba893
Fix preview bin directory for git bash
ladevieq May 3, 2020
028ddb3
Remove forgotten comment
ladevieq May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion autoload/fzf/vim.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ if s:is_win
else
let s:bin.preview = fnamemodify(s:bin.preview, ':8')
endif
let s:bin.preview = 'bash '.escape(s:bin.preview, '\')
let git_bash_bin = 'bash /mnt/'.substitute(s:bin.preview, '\([A-Z]\):', '\L\1\e', '')
Copy link
Contributor

@janlazo janlazo May 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is /mnt/ here? What if git installed with another method? What if the bash executable is not git bash?

Copy link
Author

@ladevieq ladevieq May 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best fix would probably be to write a Powershell script that would be use for windows.
This would require to bypass the execution policy, see. I'm not sure this can be done without admin rights.

If you are ok with this, i can create another PR with a Powershell script.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with it but the powershell script should be cross-platform if possible so that it can be tested on Linux.

let s:bin.preview = substitute(git_bash_bin, '\', '/', 'g')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to use mixed paths without using cygpath, ok. Problem is if it breaks the shortpath for Vim.

endif

let s:wide = 120
Expand Down