Asking for password on git 1.7

[matze]

I wanted to install plugins on a slightly older machine with Git 1.7.7 and Vim 7.3 (+ruby). For some reason, vim-plug tries to clone URLs like https://git:@github.com/Shougo/neosnippet.git. This looks to me like trying to clone with user "git:" but you seem to have a reason to construct the URL like that. Anyway, that breaks for me because I cannot type in passwords and Vim gets locked up.

P.S.: Replacing that URI with plain 'https://github.com/' ... solves the problem.

[junegunn]

Hi, thanks for pointing out the issue.

The git: prefix was introduced to workaround the problem where git asks for username when the repository doesn't exist, for example

> git clone https://github.com/tpope/vim-tpope.git
Cloning into 'vim-tpope'...
Username for 'https://github.com':

> git clone https://git:@github.com/tpope/vim-tpope.git
Cloning into 'vim-tpope'...
error: Could not resolve host: github.com while accessing https://git:@github.com/tpope/vim-tpope.git/info/refs?service=git-upload-pack
fatal: HTTP request failed

Hmm, maybe we could change the prefix to something like git:git. I currently don't have git 1.7.7 installed, could you check if git clone https://git:git@github.com/tpope/vim-tpope.git doesn't ask for anything?

[matze]

That seems to work:

$ git clone https://git:git@github.com/tpope/vim-tpope.git
Cloning into vim-tpope...
error: The requested URL returned error: 403 while accessing https://git:git@github.com/tpope/vim-tpope.git/info/refs

fatal: HTTP request failed

$ git clone https://git:@github.com/tpope/vim-tpope.git
Cloning into vim-tpope...
Password: ^C

[junegunn]

Thanks, how about git clone https://git::@github.com/tpope/vim-tpope.git? Does this work as well? (looks less silly than git:git I think)

If it works, we can easily fix this issue by putting a dummy password after :. But before doing that, I'd like to investigate if there's a better way of handling this.

[junegunn]

Okay, I downloaded git 1.7.8 and checked git:: also works.

[matze]

Same for 1.7.7.

[junegunn]

I decided to change the prefix to git::. The change is backward-compatible.
Could you update and check if it resolves the problem?

[matze]

It resolved the issue, thank you very much.