Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix electionSelect #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix electionSelect #143

wants to merge 1 commit into from

Conversation

JesseSilverberg
Copy link
Collaborator

@JesseSilverberg JesseSilverberg commented Jun 7, 2021

Currently the electionSelect is blank. The reason for this is that it only displays relevantElections, as defined in Search.js. The logic there to parse the state from the query wasn't correctly parsing my input string (see screenshot).

Screen Shot 2021-06-07 at 7 18 27 PM

My solution was to offload the parsing to Google, since they return a parsed address in some of their responses. I tried grabbing normalizedAddress from AppContext, but that would only work if I messed with the search bar again once I was on the results page. What I ended up doing is separating the calls to representatives and voterinfo, feeding the parsed address from representatives into the relevantElections logic and then pass the calculated election ID to the voterinfo call. I suppose this is a slight performance hit; if there is another place to get the parsed address that I missed, that might be better (maybe Mapbox?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant