Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert disallowing private lifecycle methods #3242

Closed
2 tasks done
marcphilipp opened this issue Apr 13, 2023 · 3 comments
Closed
2 tasks done

Revert disallowing private lifecycle methods #3242

marcphilipp opened this issue Apr 13, 2023 · 3 comments
Assignees
@marcphilipp
Labels
component: Jupiter theme: documentation type: bug
Milestone
5.9.3

Comments

@marcphilipp
Copy link
Member

marcphilipp commented Apr 13, 2023 •
edited
Loading

In #2914 validation was added to fail when encountering private lifecycle methods. Since we've received reports from multiple users that this broke tests for them, we should revert this change. Instead, we should document that using private for lifecycle methods is discouraged and support for them is likely to be removed in the next major release.

Deliverables

  • Revert validation for private lifecycle methods
  • Document private as being discouraged
@marcphilipp marcphilipp added this to the 5.9.3 milestone Apr 13, 2023
@marcphilipp marcphilipp self-assigned this Apr 13, 2023
@marcphilipp marcphilipp mentioned this issue Apr 13, 2023
Closed
@sbrannen
Copy link
Member

Reopening to backport to 5.9.3.

@sbrannen sbrannen reopened this Apr 22, 2023
marcphilipp added a commit that referenced this issue Apr 22, 2023
@marcphilipp
Revert disallowing private lifecycle methods
ee34052 
Document using private as being strongly discouraged.

Resolves #3242.

(cherry picked from commit 594f7e4)
@marcphilipp
Copy link
Member Author

Cherry-picked to the releases/5.9.x branch.

This was referenced Nov 7, 2023
Closed
Closed
@sbrannen
Copy link
Member

Closely related to:

@sbrannen sbrannen mentioned this issue Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcphilipp marcphilipp

Labels
component: Jupiter theme: documentation type: bug
Projects
None yet
Milestone
5.9.3
Development

No branches or pull requests
2 participants
@sbrannen @marcphilipp