Let @TempDir fail fast with File annotated element and non-default file system temp directory
#3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scordio
changed the title
elementType parameter to CloseablePath constructor@TempDir fail fast if createTempDirectory returns a non-default file system Path for File annotated element
scordio
changed the title
@TempDir fail fast if createTempDirectory returns a non-default file system Path for File annotated element@TempDir fail fast with File annotated element and non-default file system Path
scordio
changed the title
@TempDir fail fast with File annotated element and non-default file system Path@TempDir fail fast with File annotated element and non-default file system temp directory
scordio
force-pushed
the
issues/3910-tempdir-on-file
branch
from
509edf8
to
169bdb1
Compare
…t file system temp directory
scordio
force-pushed
the
issues/3910-tempdir-on-file
branch
from
169bdb1
to
1591388
Compare
|
@marcphilipp, I don't expect more code changes unless you see something that needs to be updated. The last point I'm considering is updating the Javadoc of |
marcphilipp
approved these changes
Aug 12, 2024
jupiter-tests/src/test/java/org/junit/jupiter/engine/extension/CloseablePathTests.java
Outdated
Show resolved
Hide resolved
scordio
force-pushed
the
issues/3910-tempdir-on-file
branch
from
322474d
to
37df841
Compare
marcphilipp
approved these changes
Aug 12, 2024
junit-jupiter-api/src/main/java/org/junit/jupiter/api/io/TempDir.java
Outdated
Show resolved
Hide resolved
Use linkplain rather than link
|
@scordio Thanks again! 🙂👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #3910.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations