Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document benefits of messageSupplier in Assertions #3938

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Document benefits of messageSupplier in Assertions #3938

merged 1 commit into from
Sep 17, 2024

Conversation

chris-carneiro
Copy link
Contributor

@chris-carneiro chris-carneiro commented Aug 28, 2024 •
edited by marcphilipp
Loading

Overview

Resolves #3153.

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@chris-carneiro chris-carneiro force-pushed the issues/3153-document-benefits-of-message-supplier-in-assertions branch from a625349 to 1069d5e Compare August 28, 2024 12:45
@chris-carneiro chris-carneiro force-pushed the issues/3153-document-benefits-of-message-supplier-in-assertions branch from 1069d5e to e8c5168 Compare September 15, 2024 16:48
marcphilipp
marcphilipp requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-carneiro Thanks for taking this on! 👍

documentation/src/docs/asciidoc/user-guide/writing-tests.adoc Outdated Show resolved Hide resolved
@chris-carneiro chris-carneiro force-pushed the issues/3153-document-benefits-of-message-supplier-in-assertions branch from e8c5168 to bb12885 Compare September 17, 2024 14:37
@chris-carneiro chris-carneiro force-pushed the issues/3153-document-benefits-of-message-supplier-in-assertions branch from bb12885 to e7b0b7c Compare September 17, 2024 14:39
@sbrannen sbrannen changed the title [Revised] Document benefits of messageSupplier in Assertions [Revised] Document benefits of messageSupplier in Assertions Sep 17, 2024
@marcphilipp marcphilipp changed the title [Revised] Document benefits of messageSupplier in Assertions Document benefits of messageSupplier in Assertions Sep 17, 2024
@marcphilipp marcphilipp merged commit 3b85a03 into junit-team:main Sep 17, 2024
15 checks passed
marcphilipp pushed a commit that referenced this pull request Sep 23, 2024
@chris-carneiro @marcphilipp
Document benefits of messageSupplier in Assertions (#3938)
3646b7d 
Resolves #3153.

(cherry picked from commit 3b85a03)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcphilipp marcphilipp marcphilipp approved these changes

Assignees
No one assigned
Labels
component: Jupiter theme: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document benefits of messageSupplier in Assertions
3 participants
@chris-carneiro @marcphilipp @sbrannen