Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add center volume commands + fix return for setVolume #73

Merged
merged 5 commits into from
Nov 25, 2020
Merged

Add center volume commands + fix return for setVolume #73

merged 5 commits into from
Nov 25, 2020

Conversation

wweich
Copy link
Contributor

@wweich wweich commented Nov 25, 2020

Status

READY

Migrations

NO

Description

Add CTL commands and add/setCernterVolume methods.

Center volume can (on my ONKYO receivers) be between -12 and +12, so the command can be CTL-C to CTL-1, CTL00and CTL+1 to CTL+C.

FIX While implementing and manual testing I saw, that the return value of setVolume was NaN. It seems, that setVolume wanted the data to be only the volume, but _parseMsg returns {MVL} as data, not MVL (which is correctly processed by getVolume).

Steps to Test or Reproduce

Try setting center volume with e.g. onkyo.sendRawCommand('CTL00')

@wweich wweich requested a review from jupe as a code owner November 25, 2020 11:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 243

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 48.128%
Totals Coverage Status
Change from base Build 242: 1.3%
Covered Lines: 232
Relevant Lines: 455
💛 - Coveralls

@jupe jupe merged commit 7eaccc8 into jupe:master Nov 25, 2020
@wweich wweich deleted the add-CTL-message branch November 25, 2020 12:21
wweich referenced this pull request in wweich/onkyo.js Apr 16, 2022
@wweich
fix return for setVolume (#73) (again)
996d6a3
@wweich wweich mentioned this pull request Apr 16, 2022
Merged
jupe pushed a commit that referenced this pull request Sep 8, 2022
@wweich
ensure 2 digits for volumeHex (#71) (again) (#142)
8c09c23 
* ensure 2 digits for volumeHex (#71) (again)

* fix return for setVolume (#73) (again)

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jupe jupe jupe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wweich @coveralls @jupe