Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move benchmark activation logic under ENABLE_TESTING #705

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

mrbald
Copy link
Contributor

@mrbald mrbald commented Mar 17, 2024

This prevents accidental benchmarks activation if prometheus-cpp is used as a submodule of a larger project, that activates benchmarks library.

This prevents accidental benchmarks activation if prometheus-cpp is used as a submodule of a larger project, that activates benchmarks library.
@mrbald
Copy link
Contributor Author

mrbald commented Mar 17, 2024

An even nicer option would be to detect that prometheus-cpp is a submodule in the top level CMakeLists.txt similar to how some other projects do it, {fmt} for example. But would probably be a bigger change.

@gjasny gjasny merged commit 284a2e2 into jupp0r:master Mar 17, 2024
10 checks passed
@gjasny
Copy link
Collaborator

gjasny commented Mar 17, 2024

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants