Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass trust to the mimerenderer #150

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Jun 1, 2023

@agoose77 This is one way to pass the trust down, I think it makes a bit of sense that the trust is in the same place as the inline expressions, but curious on your thoughts!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Binder 👈 Launch a Binder on branch executablebooks/jupyterlab-myst/feat/jlab4-trust

@rowanc1 rowanc1 added the enhancement New feature or request label Jun 1, 2023
@agoose77
Copy link
Collaborator

agoose77 commented Jun 1, 2023

Gah! I must have stopped short of actually passing this down; that was my intention!

@agoose77 agoose77 merged commit e4fb814 into agoose77/feat-jupyterlab-v4 Jun 1, 2023
@agoose77 agoose77 deleted the feat/jlab4-trust branch June 1, 2023 19:44
agoose77 pushed a commit that referenced this pull request Jun 11, 2023
rowanc1 added a commit that referenced this pull request Jun 23, 2023
* Rework dependencies (#139)
* 🎨 Theme updates for showing proofs, algorithms, and github previews (#140)
* 🎨 Update for showing proofs
* Update Playwright Snapshots
* Pass trust to the mimerenderer (#150)
* Update `@jupyterlab/galata`?
* 🧪 Pass in request to `galata`
* Try `npm_client: jlpm`
* 🧹 Update yml formatting, to trigger build!
* Only reuse expressions if the model exists
* Remove block lifting
* Upgrade myst packages
* Turn ts-error into lint warning
* Fix local images in markdown files
* Add abbreviations and glossary transforms
* Fake get rid of the double render
* Backwards compatible with Jupyterlab3
* Consistent setters/getters on cell metadata
---------

Co-authored-by: Rowan Cockett <rowanc1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants