Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: don't render list items as task items #223

Merged
merged 2 commits into from
Feb 29, 2024
Merged

FIX: don't render list items as task items #223

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6850ef5
fix: don't render list items as task items
tavin Feb 28, 2024
ad6ee58
Update src/components/listItem.tsx
agoose77 Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/listItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export function ListItem({
line?: number;
children?: any[];
}): JSX.Element {
if (checked === null) {
if (checked === undefined) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (checked == null) { would catch both cases!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's academic, but under what circumstances can checked actually be null?

agoose77 marked this conversation as resolved.
Show resolved Hide resolved
return (
<li>
<MyST ast={children} />
Expand Down
Loading