🧮 Frontmatter in include files removed, math/abbreviations maintained
#1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This begins to address the "latex subfile" task here: econ-ark/REMARK#152 |
|
Also, as a side effect, this addresses the first half of #1152 - now, when providing a non-existent file at the CLI, you are told it does not exist. (Complaints about the extension will only surface if the file exists but has a bad extension. Anyway - still more to do on that one...) |
fwkoch
commented
Apr 24, 2024
| @@ -70,7 +77,7 @@ export function getFrontmatter( | |||
| if (nextNodeIsH1 && !titleNull) { | |||
| const title = toText(nextNode.children); | |||
| // Only remove the title if it is the same | |||
| if (frontmatter.title && frontmatter.title === title) { | |||
| if (frontmatter.title && frontmatter.title === title && !opts.keepTitleNode) { | |||
There was a problem hiding this comment.
I think an option like this existed before, and I got rid of it a little hastily... Now, we can once again leave the title node in the tree. Useful for include files where we almost certainly do not want to remove headings.
fwkoch
commented
Apr 24, 2024
|
|
||
| try { | ||
| const content = fs.readFileSync(file).toString(); |
There was a problem hiding this comment.
Error early on file does not exist.
|
Tested locally, works well! |
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files loaded in the
includedirective previously retained their frontmatter in themdasttree, resulting in an unwantedyamlcode block. Additionally, everything in theincludefrontmatter was ignored (mostly we do want to ignore it, but for.texsource files,includes may have math macros, etc, that we need to inherit).Now, we reuse the file loading functions from
loadFilein theincludedirective. These functions remove and give access to file frontmatter. That means no more yaml blocks and we can inheritmathandabbreviationsinto the parent file's frontmatter.