⚡️ fix/improve async load #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
stevejpurves
force-pushed
the
fix/improve-async-load
branch
from
f0412fe to
cdd742b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thebe-corebundles a number of jupyterlab libraries which makes building with build systems other than webpack difficult, and building for the remix framework for example has require package patching to date.As when using
thebe-llitea consumer is faced with sideloading the library to the page anyway, we've modified thethebe-reactasync loading strategy to load bundles directly for both core and lite. This provides a programmatic way for loading both from their bundles, solving a bunch of downstream issues e.g. inmyst-theme.The original
ThebeLoaderProvideris still available is the preference is to still include the package in the downstream build step.A new loader
ThebeBundleLoaderProviderwill load the libraries using the new strategy and requires the downstream build process to make the libraries available on the correct path.