Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spell check and ensure docstrings #1226

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Add spell check and ensure docstrings #1226

merged 3 commits into from
Jan 9, 2023

Conversation

blink1073
Copy link
Contributor

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 23, 2022
View reviewed changes
docs/source/conf.py
import enchant # noqa

extensions += ["sphinxcontrib.spelling"]
except ImportError:

Check notice

Code scanning / CodeQL

Empty except

'except' clause does nothing but pass and there is no explanatory comment.
docs/source/conf.py
@@ -36,6 +36,13 @@
"sphinxemoji.sphinxemoji",
]

try:
import enchant # noqa

Check notice

Code scanning / CodeQL

Unused import

Import of 'enchant' is not used.
kevin-bates
kevin-bates approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steve!

@kevin-bates kevin-bates merged commit dcaeb56 into jupyter-server:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @kevin-bates