-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server-side support for event-driven notebook execution #416
Draft
andrii-i
wants to merge
19
commits into
jupyter-server:main
Choose a base branch
from
andrii-i:event_driven_execution
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-i
changed the title
Server-side support for event driven notebook execution
Server-side support for event-driven notebook execution
Aug 9, 2023
3coins
reviewed
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrii-i
Thanks for working on this. Left some comments about naming of events attribute.
Thank you for the review @3coins |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
andrii-i
force-pushed
the
event_driven_execution
branch
from
August 14, 2023 21:37
79082b7
to
eaa3923
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds server-side support for event-driven notebook execution, fixes #406 (for UI see #414).
System now defines
EventTypes
andEvents
.EventType
is specific condition identified by a name and a set of parameters.Event
is a unique occurrence of the certain event type.Event types can be defined through
RuntimeEnvironment.event_types[]
. Event occurrences are supposed to originate from outside of JupyterLab, from the broader environment where it operates. When an event of a certain type occurs, all job definitions associated with the event type (JobDefinition.events[]
has an item with matchingname
) are supposed to be queried. This PR does not provide a mechanism to kick-off the event occurrence and does not manage querying of matching job definitions, it just provides models and handlers to support the process.Changes
Non-breaking REST API changes:
POST /job-definition
Existing endpoint to create or update a job definition. Add new optional parameter events that contains array of event types that trigger job definition execution
Request schema:
POST /job
Existing endpoint to create or update a job. Add optional parameter
triggered_by
that contains an event that triggered the job executionRequest schema:
Changes to existing models
RuntimeEnvironment:
CreateJob, DescribeJob:
CreateJobDefinition, DescribeJobDefinition, UpdateJobDefinition:
New models
Changes to existing models
ORM changes