Skip to content

Commit

Permalink
Merge pull request #268 from wolfv/forward_check_python
Browse files Browse the repository at this point in the history
  • Loading branch information
blink1073 authored Mar 15, 2022
2 parents 54ee402 + a48f996 commit bf20b46
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 4 deletions.
17 changes: 15 additions & 2 deletions jupyter_releaser/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -600,13 +600,26 @@ def delete_release(auth, release_url):
@add_options(dry_run_options)
@add_options(npm_install_options)
@add_options(pydist_check_options)
@add_options(check_imports_options)
@click.argument("release-url", nargs=1)
def extract_release(
auth, dist_dir, dry_run, release_url, npm_install_options, pydist_check_cmd
auth,
dist_dir,
dry_run,
release_url,
npm_install_options,
pydist_check_cmd,
check_imports,
):
"""Download and verify assets from a draft GitHub release"""
lib.extract_release(
auth, dist_dir, dry_run, release_url, npm_install_options, pydist_check_cmd
auth,
dist_dir,
dry_run,
release_url,
npm_install_options,
pydist_check_cmd,
check_imports,
)


Expand Down
14 changes: 12 additions & 2 deletions jupyter_releaser/lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,13 @@ def delete_release(auth, release_url):


def extract_release(
auth, dist_dir, dry_run, release_url, npm_install_options, pydist_check_cmd
auth,
dist_dir,
dry_run,
release_url,
npm_install_options,
pydist_check_cmd,
python_imports,
):
"""Download and verify assets from a draft GitHub release"""
match = parse_release_url(release_url)
Expand Down Expand Up @@ -338,7 +344,11 @@ def extract_release(
for asset in assets:
suffix = Path(asset.name).suffix
if suffix in [".gz", ".whl"]:
python.check_dist(dist / asset.name, check_cmd=pydist_check_cmd)
python.check_dist(
dist / asset.name,
check_cmd=pydist_check_cmd,
python_imports=python_imports,
)
elif suffix == ".tgz":
pass # already handled
else:
Expand Down

0 comments on commit bf20b46

Please sign in to comment.