Skip to content

Commit

Permalink
Merge pull request #399 from kevin-bates/default-async-km
Browse files Browse the repository at this point in the history
Use async kernel manager by default
  • Loading branch information
Zsailer authored Feb 3, 2021
2 parents 1ca52a8 + 9035592 commit 122d93a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions jupyter_server/gateway/managers.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from tornado.escape import json_encode, json_decode, url_escape
from tornado.httpclient import HTTPClient, AsyncHTTPClient, HTTPError

from ..services.kernels.kernelmanager import MappingKernelManager
from ..services.kernels.kernelmanager import AsyncMappingKernelManager
from ..services.sessions.sessionmanager import SessionManager

from jupyter_client.kernelspec import KernelSpecManager
Expand Down Expand Up @@ -329,7 +329,7 @@ async def gateway_request(endpoint, **kwargs):
return response


class GatewayKernelManager(MappingKernelManager):
class GatewayKernelManager(AsyncMappingKernelManager):
"""Kernel manager that supports remote kernels hosted by Jupyter Kernel or Enterprise Gateway."""

# We'll maintain our own set of kernel ids
Expand Down
3 changes: 2 additions & 1 deletion jupyter_server/serverapp.py
Original file line number Diff line number Diff line change
Expand Up @@ -1130,7 +1130,8 @@ def _update_notebook_dir(self, change):
self.root_dir = change['new']

kernel_manager_class = Type(
default_value=MappingKernelManager,
default_value=AsyncMappingKernelManager,
klass=MappingKernelManager,
config=True,
help=_('The kernel manager class to use.')
)
Expand Down

0 comments on commit 122d93a

Please sign in to comment.