Skip to content

Commit

Permalink
Fix nbconvert handler run_sync() (#667)
Browse files Browse the repository at this point in the history
  • Loading branch information
davidbrochart authored Jan 18, 2022
1 parent 923a828 commit d201529
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions jupyter_server/nbconvert/handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ async def get(self, format, path):
# Exporting can take a while, delegate to a thread so we don't block the event loop
try:
output, resources = await run_sync(
exporter.from_notebook_node(nb, resources=resource_dict)
lambda: exporter.from_notebook_node(nb, resources=resource_dict)
)
except Exception as e:
self.log.exception("nbconvert failed: %s", e)
Expand All @@ -146,22 +146,22 @@ class NbconvertPostHandler(JupyterHandler):
SUPPORTED_METHODS = ("POST",)

@web.authenticated
def post(self, format):
async def post(self, format):
exporter = get_exporter(format, config=self.config)

model = self.get_json_body()
name = model.get("name", "notebook.ipynb")
nbnode = from_dict(model["content"])

try:
output, resources = exporter.from_notebook_node(
nbnode,
resources={
"metadata": {
"name": name[: name.rfind(".")],
output, resources = await run_sync(
lambda: exporter.from_notebook_node(
nbnode,
resources={
"metadata": {"name": name[: name.rfind(".")]},
"config_dir": self.application.settings["config_dir"],
},
"config_dir": self.application.settings["config_dir"],
},
)
)
except Exception as e:
raise web.HTTPError(500, "nbconvert failed: %s" % e) from e
Expand Down

0 comments on commit d201529

Please sign in to comment.