Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions in CI #143

Closed
echarles opened this issue Dec 2, 2019 · 4 comments
Closed

Add GitHub Actions in CI #143

echarles opened this issue Dec 2, 2019 · 4 comments
Labels
enhancement
Milestone
0.2.0 Release

Comments

@echarles
Copy link
Member

echarles commented Dec 2, 2019

We have for now travis and appveyor for the CI. Travis shows to be a bit flaky, while my experience with GitHub actions is very good.

What about replacing Travis with GitHub Actions?
@echarles echarles mentioned this issue Dec 2, 2019
Merged
@rolweber
Copy link
Contributor

rolweber commented Dec 2, 2019

If somebody volunteers to implement tests with GitHub Actions, it certainly wouldn't hurt to have those running in parallel with Travis for a while. The decision whether to disable one or the other can be deferred until we know how well both are working, in direct comparison.

@maartenbreddels
Copy link
Contributor

Yes, I've done the same with vaex where GitHub actions give me fast feedback, but I'm keeping Travis/AppVeyor around for a while.

@kevin-bates
Copy link
Member

@Zsailer has been reworking the tests (moving to pytest and using GH actions): https://github.com/Zsailer/jupyter_server_tests

I agree it would be good to keep Travis and appveyor in the mix until we can confirm GHA meets our needs.

@echarles echarles changed the title Replace Travis with GitHub Actions Add GitHub Actions in CI Dec 2, 2019
@Zsailer Zsailer added this to the 0.2.0 Release milestone Dec 2, 2019
@echarles echarles mentioned this issue Dec 2, 2019
Merged
@echarles
Copy link
Member Author

echarles commented Dec 3, 2019

Done with #146

@echarles echarles closed this as completed Dec 3, 2019
Zsailer added a commit to Zsailer/jupyter_server that referenced this issue Nov 18, 2022
@Zsailer
Chaining rio tests again. (jupyter-server#143)
c091e6b 
* remove git push trigger

* Bump to 0.12.9

* trigger docker build after pypi tests

* remove the PR trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.2.0 Release
Development

No branches or pull requests
5 participants
@echarles @maartenbreddels @Zsailer @rolweber @kevin-bates