-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure extensions from server CLI. #55
Comments
Could you describe what is the user/consumer experience here? I believe @kevin-bates and I were talking about similar scenario for integrating EG on JupyterServer Phase 2. |
For example, passing a spawner argument for JupyterLab in a JupyterHub deployment. (E.g. static_url if using a cdn). |
cc @ian-r-rose |
For example, imagine a user launches a jupyter_server with
Any extension that's configurable and enabled could be configured from the CLI. |
This works in #180. All CLI arguments are parsed by the ServerApp and stored in a general traitlets Config({
"ServerApp": {
"default_url": "/lab"
},
"NotebookApp: {
"enable_mathjax: False
},
"LabApp": {
"workspaces_dir": "/path/to/workspace"
}
}) This object is then passed to and shared by all the extensions. Each extension will update it's config with the piece that's relevant to its config. We should close this issue once that is merged. |
This idea was raised in jupyterlab/jupyterlab#6451.
Problem: the classic notebook can configure both the server and the frontend from the CLI. This is helpful for scenarios where you are deploying jupyter servers from scripts. JupyterHub, for example, launches single-user server using the CLI entry points. Those running notebook or lab as server extensions cannot configure those frontends from the
jupyter server
CLI.Soluton: I propose we add functionality to Jupyter Server that enables the
jupyter server
CLI to configure extensions (assuming they are configurable objects). This would requireServerApp
to look for enabled, configurable extensions and dynamically add those classes to the ServerApp'sclasses
trait.The text was updated successfully, but these errors were encountered: