Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coroutine 'async_replace_file' is not awaited #594

Closed
Wh1isper opened this issue Oct 20, 2021 · 3 comments
Closed

Coroutine 'async_replace_file' is not awaited #594

Wh1isper opened this issue Oct 20, 2021 · 3 comments
Labels

Comments

@Wh1isper
Copy link
Contributor

Description

https://github.com/jupyter-server/jupyter_server/blob/master/jupyter_server/services/contents/fileio.py#L376

I am currently reading the source code for file operations noticed that it seems to be missing await when call 'async_replace_file'

I'm not sure if this will cause problems

Reproduce

Expected behavior

Context

  • Operating System and version:
  • Browser and version:
  • Jupyter Server version: master(1.12.0.dev0)
Troubleshoot Output
Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.
Command Line Output
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.
Browser Output
Paste the output from your browser Javascript console here, if applicable.
@Wh1isper Wh1isper added the bug label Oct 20, 2021
@welcome
Copy link

welcome bot commented Oct 20, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@Wh1isper
Copy link
Contributor Author

I created a pr: #595

It's better to fix it, isn't it?

:)

@blink1073
Copy link
Contributor

Fixed in #595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants