Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing await when call 'async_replace_file' #595

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

Wh1isper
Copy link
Contributor

@Wh1isper Wh1isper commented Oct 20, 2021

#594

I am currently reading the source code for file operations noticed that it seems to be missing await when call 'async_replace_file'

It's better to fix it, isn't it?

@welcome
Copy link

welcome bot commented Oct 20, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit f944deb into jupyter-server:master Oct 20, 2021
@welcome
Copy link

welcome bot commented Oct 20, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants