Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Batch 5] Porting Notebook PRs #103

Merged
merged 5 commits into from
Sep 27, 2019
Merged

[Batch 5] Porting Notebook PRs #103

merged 5 commits into from
Sep 27, 2019

Commits on Sep 27, 2019

  1. changing file name to lower case before checking if file extension is… 

    … ipynb
    @EvgeniDubov @Zsailer
    EvgeniDubov authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    fdad83c View commit details
    Browse the repository at this point in the history

  2. Call tornado WebSocketHandler.get() as a coroutine 

    This change will probably be needed for Tornado 6. Ben Darnell figured it out.
https://groups.google.com/d/msg/python-tornado/mSeG7Kc6z4o/baeTDOvJGgAJ
    @takluyver @Zsailer
    takluyver authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    e1b5985 View commit details
    Browse the repository at this point in the history

  3. Enable restart_kernel for async usage 

    Converted `MappingKernelManager.restart_kernel` to a coroutine so that
projects that take advantage of async kernel startup can also realize
appropriate behavior relative to restarts.
    @kevin-bates @Zsailer
    kevin-bates authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    97fbda8 View commit details
    Browse the repository at this point in the history

  4. remove unused import of os 

    found by lgtm
    @fchapoton @Zsailer
    fchapoton authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    0060310 View commit details
    Browse the repository at this point in the history

  5. remove selenium from notebook

    @Zsailer
    Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    63d3609 View commit details
    Browse the repository at this point in the history