Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make node optional #1030

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Make node optional #1030

merged 4 commits into from
Oct 14, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Oct 14, 2022 •
edited
Loading

Added SKIP_JUPYTER_BUILDER=1 to readthedocs config for the project.
When installing in editable mode locally, node is now optional.

@blink1073 blink1073 closed this Oct 14, 2022
@blink1073 blink1073 reopened this Oct 14, 2022
@blink1073 blink1073 changed the title Try making node optional again Make node optional Oct 14, 2022
@blink1073 blink1073 enabled auto-merge (squash) October 14, 2022 12:37
@blink1073 blink1073 merged commit 712c453 into jupyter-server:main Oct 14, 2022
@blink1073 blink1073 deleted the fix-optional-node branch October 14, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@blink1073