Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global env for min version check #1048

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

blink1073
Copy link
Contributor

No description provided.

@vidartf
Copy link
Member

vidartf commented Nov 3, 2022

Thanks! AFAICT , this issue is not present on the 1.x branch, so we should be reasonably confident that there are no issues there. 👍

@blink1073
Copy link
Contributor Author

We're getting hit by https://www.githubstatus.com/incidents/zbr492f1vzcy

@blink1073 blink1073 closed this Nov 3, 2022
@blink1073 blink1073 reopened this Nov 3, 2022
@blink1073 blink1073 enabled auto-merge (squash) November 3, 2022 17:23
@codecov-commenter
Copy link

Codecov Report

Base: 73.10% // Head: 73.10% // No change to project coverage 👍

Coverage data is based on head (6248586) compared to base (27c30ad).
Patch has no changes to coverable lines.

❗ Current head 6248586 differs from pull request most recent head db58cb0. Consider uploading reports for the commit db58cb0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   73.10%   73.10%           
=======================================
  Files          64       64           
  Lines        8274     8274           
  Branches     1643     1643           
=======================================
  Hits         6049     6049           
  Misses       1816     1816           
  Partials      409      409           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit 4b2ac37 into jupyter-server:main Nov 3, 2022
@blink1073 blink1073 deleted the fix-min-version-check branch November 3, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants