Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove python 3.4 branch #1061

Merged
merged 2 commits into from
Nov 8, 2022
Merged

MAINT: remove python 3.4 branch #1061

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c21ec1
MAINT: remove python 3.4 branch
Carreau Nov 8, 2022
fb2c660
remove unused import
blink1073 Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions jupyter_server/base/zmqhandlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import json
import re
import struct
import sys
from typing import Optional, no_type_check
from urllib.parse import urlparse

Expand Down Expand Up @@ -42,8 +41,6 @@ def serialize_binary_message(msg):
# don't modify msg or buffer list in-place
msg = msg.copy()
buffers = list(msg.pop("buffers"))
if sys.version_info < (3, 4):
buffers = [x.tobytes() for x in buffers]
bmsg = json.dumps(msg, default=json_default).encode("utf8")
buffers.insert(0, bmsg)
nbufs = len(buffers)
Expand Down