Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call ports_changed on the multi-kernel-manager instead of the kernel manager #1088

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Call ports_changed on the multi-kernel-manager instead of the kernel manager #1088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jupyter_server/services/kernels/connection/channels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ def connect(self):
buffer_info = self.multi_kernel_manager.get_buffer(self.kernel_id, self.session_key)
if buffer_info and buffer_info["session_key"] == self.session_key:
self.log.info("Restoring connection for %s", self.session_key)
if self.kernel_manager.ports_changed(self.kernel_id):
if self.multi_kernel_manager.ports_changed(self.kernel_id):
# If the kernel's ports have changed (some restarts trigger this)
# then reset the channels so nudge() is using the correct iopub channel
self.create_stream()
Expand Down