-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kernel WebSocket protocol #1110
Conversation
4db76ba
to
471c3ee
Compare
Codecov ReportBase: 80.03% // Head: 39.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
===========================================
- Coverage 80.03% 39.33% -40.71%
===========================================
Files 68 68
Lines 8011 8013 +2
Branches 1586 1586
===========================================
- Hits 6412 3152 -3260
- Misses 1178 4665 +3487
+ Partials 421 196 -225
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
72c848c
to
9631a40
Compare
9631a40
to
c0f3f3c
Compare
You're the man, David! 🚀 Thank you for working on this. I'll give this a review later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @davidbrochart!
Fixes #1103
Fixes jupyterlab/jupyterlab#13481