Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kernel WebSocket protocol #1110

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

davidbrochart
Copy link
Contributor

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 80.03% // Head: 39.33% // Decreases project coverage by -40.70% ⚠️

Coverage data is based on head (72c848c) compared to base (c2275a7).
Patch coverage: 33.33% of modified lines in pull request are covered.

❗ Current head 72c848c differs from pull request most recent head c0f3f3c. Consider uploading reports for the commit c0f3f3c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1110       +/-   ##
===========================================
- Coverage   80.03%   39.33%   -40.71%     
===========================================
  Files          68       68               
  Lines        8011     8013        +2     
  Branches     1586     1586               
===========================================
- Hits         6412     3152     -3260     
- Misses       1178     4665     +3487     
+ Partials      421      196      -225     
Impacted Files Coverage Δ
jupyter_server/services/kernels/websocket.py 38.00% <12.50%> (-45.34%) ⬇️
...ter_server/services/kernels/connection/channels.py 16.11% <75.00%> (-43.37%) ⬇️
...pyter_server/services/contents/largefilemanager.py 11.11% <0.00%> (-72.73%) ⬇️
jupyter_server/services/contents/fileio.py 22.10% <0.00%> (-67.90%) ⬇️
...upyter_server/services/contents/filecheckpoints.py 22.35% <0.00%> (-67.65%) ⬇️
jupyter_server/gateway/handlers.py 0.00% <0.00%> (-61.82%) ⬇️
jupyter_server/services/sessions/sessionmanager.py 27.18% <0.00%> (-61.30%) ⬇️
jupyter_server/auth/utils.py 33.33% <0.00%> (-60.61%) ⬇️
jupyter_server/services/contents/filemanager.py 13.98% <0.00%> (-60.59%) ⬇️
jupyter_server/services/contents/manager.py 27.33% <0.00%> (-59.00%) ⬇️
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidbrochart davidbrochart force-pushed the subprotocol branch 2 times, most recently from 72c848c to 9631a40 Compare December 2, 2022 16:15
@Zsailer
Copy link
Member

Zsailer commented Dec 2, 2022

You're the man, David! 🚀 Thank you for working on this. I'll give this a review later today.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @davidbrochart!

@Zsailer Zsailer merged commit 53380a7 into jupyter-server:main Dec 2, 2022
@davidbrochart davidbrochart deleted the subprotocol branch December 2, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websocket header error Example CI is failing on master
3 participants