Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests less sensitive to default kernel name #1118

Merged

Conversation

blink1073
Copy link
Contributor

The native kernel is faster, so we'd like to switch the default back in jupyter-server/pytest-jupyter#36. This change makes us less brittle.

@blink1073 blink1073 enabled auto-merge (squash) December 6, 2022 12:14
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 80.01% // Head: 80.04% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (a85405a) compared to base (118ac89).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
+ Coverage   80.01%   80.04%   +0.02%     
==========================================
  Files          68       68              
  Lines        8013     8013              
  Branches     1586     1586              
==========================================
+ Hits         6412     6414       +2     
+ Misses       1179     1178       -1     
+ Partials      422      421       -1     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 80.21% <0.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit 312327f into jupyter-server:main Dec 6, 2022
@blink1073 blink1073 deleted the use-python-by-default-in-tests branch December 6, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant