Revert "Make preferred_dir content manager trait" #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a55bc58.
Codecov ReportBase: 79.91% // Head: 79.84% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
- Coverage 79.91% 79.84% -0.08%
==========================================
Files 68 68
Lines 8067 8048 -19
Branches 1599 1596 -3
==========================================
- Hits 6447 6426 -21
- Misses 1197 1200 +3
+ Partials 423 422 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Yes please resolve. I'll have a look next year :)
…On Mon, 19 Dec 2022, 23:28 Steven Silvester, ***@***.***> wrote:
cc @vidartf <https://github.com/vidartf>, @Zsailer
<https://github.com/Zsailer> and I had a chat about this. I'll plan to
merge this, cut a patch release, and then re-apply tomorrow if you haven't
had a chance to resolve.
—
Reply to this email directly, view it on GitHub
<#1140 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD4WKA2V6AN3IGADCJXHH3WODVRPANCNFSM6AAAAAATD4MGQI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
*revert
…On Mon, 19 Dec 2022, 23:49 Vidar Tonaas Fauske, ***@***.***> wrote:
Yes please resolve. I'll have a look next year :)
On Mon, 19 Dec 2022, 23:28 Steven Silvester, ***@***.***>
wrote:
> cc @vidartf <https://github.com/vidartf>, @Zsailer
> <https://github.com/Zsailer> and I had a chat about this. I'll plan to
> merge this, cut a patch release, and then re-apply tomorrow if you haven't
> had a chance to resolve.
>
> —
> Reply to this email directly, view it on GitHub
> <#1140 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAD4WKA2V6AN3IGADCJXHH3WODVRPANCNFSM6AAAAAATD4MGQI>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
vidartf
added a commit
to vidartf/jupyter_server
that referenced
this pull request
Jan 4, 2023
…rver#1140)" This reverts commit b5b7c5e.
blink1073
pushed a commit
that referenced
this pull request
Jan 4, 2023
…1162) * Revert "Revert "Make preferred_dir content manager trait" (#1140)" This reverts commit b5b7c5e. * Write back pref dir to app for backwards compat This way, anyone that reads out the old value will not break (except if the path is not a FS path, in which case it doesn't currently work anyways). * Fix: serverapp needs absolute path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #983