cleaning up PR#113 #115
Merged
cleaning up PR#113 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidartf
reviewed
Oct 9, 2019
willingc
approved these changes
Oct 10, 2019
|
Thanks! I'm happy to merge this as is. I'll do another pass on the full changes after, especially w.r.t. writing some more tests (the issues I pointed out should ideally have been picked up by some tests). |
|
@vidartf 👍 Sounds good. Merge away. Thanks for your help reviewing! |
|
Have not tested this PR but from the diff, it sounds like a needed change that will fix the absence of token when the browser is launched. LGTM. |
I don't have merge rights though, so someone else would have to push the button. 😉 |
|
I.e. |
|
@vidartf I've given you merge rights. Check your inbox. And merge away ☀️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing comments from #113.
@vidartf