Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preferred_dir for sync contents manager #1173

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

vidartf
Copy link
Member

@vidartf vidartf commented Jan 12, 2023

Also includes a regression test.

@vidartf vidartf added the bug label Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 79.93% // Head: 80.08% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (5ca45f2) compared to base (a6dea1b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
+ Coverage   79.93%   80.08%   +0.14%     
==========================================
  Files          68       68              
  Lines        8124     8153      +29     
  Branches     1601     1606       +5     
==========================================
+ Hits         6494     6529      +35     
+ Misses       1205     1196       -9     
- Partials      425      428       +3     
Impacted Files Coverage Δ
jupyter_server/services/contents/manager.py 85.39% <100.00%> (+0.09%) ⬆️
jupyter_server/services/sessions/handlers.py 79.20% <0.00%> (-1.95%) ⬇️
jupyter_server/serverapp.py 79.92% <0.00%> (ø)
jupyter_server/utils.py 85.46% <0.00%> (+0.17%) ⬆️
jupyter_server/services/sessions/sessionmanager.py 88.36% <0.00%> (+0.36%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 81.87% <0.00%> (+0.70%) ⬆️
jupyter_server/extension/utils.py 84.44% <0.00%> (+2.39%) ⬆️
jupyter_server/terminal/__init__.py 100.00% <0.00%> (+100.00%) ⬆️
jupyter_server/terminal/handlers.py 100.00% <0.00%> (+100.00%) ⬆️
jupyter_server/terminal/api_handlers.py 100.00% <0.00%> (+100.00%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants