Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove upper bound on anyio #1192

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Feb 1, 2023

upper-bound pin added during dependency sorting in #675, for no reason I can see. Perhaps by accident, since there is no anyio 4, and there's no reason to suspect it would break our use.

It's generally desirable to avoid upper bounds in Python because they tend to create far more problems than they solve (in packages, self-contained applications have different needs).

Upper bounds should generally only be added in packages:

  • if a known incompatibility has been identified, and
  • with an immediate issue/pr to revert the pin flagging that it's a pressing issue to fix, because upper bounds themselves are a problem that needs fixing if it excludes the latest version of something.

pin during dependency sorted, apparently not on purpose
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 79.78% // Head: 80.41% // Increases project coverage by +0.62% 🎉

Coverage data is based on head (d3e06a5) compared to base (beb0d45).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1192      +/-   ##
==========================================
+ Coverage   79.78%   80.41%   +0.62%     
==========================================
  Files          68       68              
  Lines        8117     8117              
  Branches     1584     1584              
==========================================
+ Hits         6476     6527      +51     
+ Misses       1207     1176      -31     
+ Partials      434      414      -20     
Impacted Files Coverage Δ
jupyter_server/gateway/managers.py 83.60% <0.00%> (+0.23%) ⬆️
jupyter_server/base/handlers.py 78.82% <0.00%> (+0.39%) ⬆️
jupyter_server/services/contents/fileio.py 90.05% <0.00%> (+1.04%) ⬆️
jupyter_server/serverapp.py 80.03% <0.00%> (+1.41%) ⬆️
jupyter_server/extension/handler.py 69.23% <0.00%> (+1.53%) ⬆️
jupyter_server/nbconvert/handlers.py 79.09% <0.00%> (+1.81%) ⬆️
jupyter_server/services/contents/filemanager.py 75.75% <0.00%> (+1.87%) ⬆️
...ter_server/services/kernels/connection/channels.py 61.72% <0.00%> (+1.99%) ⬆️
jupyter_server/utils.py 85.46% <0.00%> (+4.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit f3fe168 into jupyter-server:main Feb 1, 2023
@SylvainCorlay
Copy link
Contributor

A reason to think it will break is the major version bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants