Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure content-type properly reflects gateway kernelspec resources #1219

Merged

Conversation

kevin-bates
Copy link
Member

The APIHandler.finish() method unconditionally overrides the header's Content-type to application/json despite the GatewayResourceHandler setting it to a mime-type corresponding to the resource's extension.

This pull request enables the caller to indicate the ContentType that should be set into the header in APIHandler.finish() where application/json is the default if no content type is specified.

Resolves: #216

Co-authored-by: Mehmet Bektas <mbektasgh@outlook.com>
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 80.46% // Head: 80.45% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (c7739fb) compared to base (ce8e7fc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1219      +/-   ##
==========================================
- Coverage   80.46%   80.45%   -0.01%     
==========================================
  Files          68       68              
  Lines        8134     8135       +1     
  Branches     1586     1586              
==========================================
  Hits         6545     6545              
- Misses       1174     1176       +2     
+ Partials      415      414       -1     
Impacted Files Coverage Δ
jupyter_server/base/handlers.py 78.86% <100.00%> (+0.04%) ⬆️
jupyter_server/gateway/handlers.py 62.27% <100.00%> (ø)
...ter_server/services/kernels/connection/channels.py 61.72% <0.00%> (-0.45%) ⬇️
jupyter_server/serverapp.py 80.05% <0.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 enabled auto-merge (squash) February 21, 2023 17:34
@blink1073 blink1073 disabled auto-merge February 21, 2023 17:59
@blink1073 blink1073 merged commit 2b42b90 into jupyter-server:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python version per platform support for extension authors
2 participants