-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows immutable cache for static files in a directory #1268
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@meeseeksdev please backport to 1.x |
Awww, sorry brichet you do not seem to be allowed to do that, please ask a repository maintainer. |
Should it be backported to 1.x ? |
@meeseeksdev please backport to 1.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
As mentioned in jupyterlab/jupyterlab#10273 and jupyterlab/jupyterlab#14124, JupyterLab now uses hashes for the javascript assets.
This PR allows to serve static files as immutable to avoid server requests (when the static files have
no-cache
header), by setting up the setting "static_immutable_cache".Additional context:
Discussed in weekly meeting jupyter-server/team-compass#45 (comment)