-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add open_browser trait to ExtensionApp #128
[MRG] add open_browser trait to ExtensionApp #128
Conversation
Should this also get a flag (inverted): |
The |
That inherited flag reads as: flags["no-browser"] = (
{"ServerApp": {"open_browser": False}},
_("Prevent the opening of the default url in the browser."),
) Is it not an issue that it says |
@vidartf As far as I have seen, the flags handling does not work as expected. I am looking at this and will open on issue (hopefully a PR). We can revisit this PR based on the findings/fixes we will get for the more global flag issue. |
This branch fails on I had that issue at other places (#117 and jupyterlab/jupyterlab#7416). I have opened #140 to further discuss this before coming back here. |
@echarles That is not how it is intended to be used though. |
PS: The right ways are either |
PPS: Or in this case |
After yesterday discussion at server weekly meeting, I now get the point that the extension flags should only be applied to an extension launched via its entrypoint. BTW, this PR does not define flag for open_browser, so my previous attempt was out of context... Sorry for the confusion. Going back to the parameters approach, I have tried to launch with Digging a bit more into the base ExtensionApp, I have the impression that the traits given via CLI are not taken into account by the ExtensionApp. e.g. Looking at the code that prepare the settings and printing those settings in the log, I feel that something must be done to feed the extension CLI config to the settings. Any input on this? |
8683061
to
e0fdaf4
Compare
@vidartf I don't think this is a problem. These traits should affect the ServerApp directly.
|
Merging, since I've addressed the concerns above. We can open a future PR if needed. |
Addresses #120.
Adds a trait to
ExtensionApp
s to configure opening browser windows on launch.