Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typings for traitlets 5.10 #1330

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Conversation

blink1073
Copy link
Contributor

There are still a few edge cases, identified in ipython/traitlets#871, but we already caught some places that could have been None.

@blink1073 blink1073 merged commit 3544deb into jupyter-server:main Sep 28, 2023
35 checks passed
@blink1073 blink1073 deleted the fix-typings branch September 28, 2023 17:54
f"proceed using the current token value. Exception was: {ex}"
)
self.auth_token = prev_auth_token
if self.auth_token:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1339 looking at this issue.

Is this the problematic line? Can we just revert this line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants