Add typings to commonly used APIs #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
reviewed
Jan 9, 2024
| @@ -603,7 +614,7 @@ async def prepare(self): | |||
| DeprecationWarning | |||
| # stacklevel not useful here | |||
| ) | |||
| user = self.get_current_user() | |||
| user = User(self.get_current_user()) | |||
There was a problem hiding this comment.
User is only imported when typechecking is on, so this actually causes an invalid import error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at which APIs were used by
jupyterlab_server,notebook, andjupyterlaband this covers most of them.