ContentsHandler return 404 rather than raise exc #1357

bloomsa · 2023-11-08T02:43:52Z

this addresses #1328. This works based on my testing but I'm more than happy to make structural changes to clean the code up. I'm admittedly not very well versed in tornado. Thanks in advance for feedback :)

bloomsa · 2023-11-08T03:17:26Z

I see one of the test actions, build (windows latest 3.9), failed but I'm not sure it's related since the code change doesn't seem to touch the affected test case

blink1073 · 2023-11-08T03:23:35Z

I see one of the test actions, build (windows latest 3.9), failed but I'm not sure it's related since the code change doesn't seem to touch the affected test case

That is a known flaky test.

blink1073 · 2023-11-08T03:26:54Z

Changes look good! Can you please add a test in https://github.com/jupyter-server/jupyter_server/blob/main/tests/services/contents/test_manager.py that tries to get a file that doesn't exist and ensures that a 404 is raised?

bloomsa · 2023-11-10T02:18:09Z

Changes look good! Can you please add a test in https://github.com/jupyter-server/jupyter_server/blob/main/tests/services/contents/test_manager.py that tries to get a file that doesn't exist and ensures that a 404 is raised?

done in my latest commit. couple of questions though

do you know what the "w" argument is on cm.get here? I'm kind of confused about it as "w" doesn't really make sense for the content argument typed as a bool (ref) is it maybe legacy from a previous iteration of the get method?
I tweaked the structure of the assertion a bit compared to the previous two assertions in the test case because I couldn't get the with pytest.raises(HTTPError) as excinfo: to be satisfied. I don't really understand how the assertions above it pass okay - my understanding is that the except should catch the exception and not trickle it up to the with. Do you want me to reformat those other assertions too? (or am I doing something totally wrong here 😅 )

blink1073 · 2023-11-10T12:15:34Z

Hey @bloomsa, I agree the w is a logic error currently. I also think the previous blocks probably suffered from the move from nose to pytest are incorrect as well. The previous one isn't actually testing anything. 😅

bloomsa · 2023-11-12T20:25:11Z

I'm working on fixing the test cases for windows (actually led me to a bug in the tests that I'll fix 👍 )
would you like me to fix these as part of this PR? I can do it no problem @blink1073

I agree the w is a logic error currently. I also think the previous blocks probably suffered from the move from nose to pytest are incorrect as well.

blink1073 · 2023-11-12T22:11:33Z

Yes please!

bloomsa · 2023-11-13T01:10:39Z

tests/services/contents/test_manager.py

+    cm.allow_hidden = True
+    hidden_dir = ".hidden"
+    file_in_hidden_path = os.path.join(hidden_dir, "visible.txt")
+    _make_dir(cm, hidden_dir)
+    model = await ensure_async(cm.new(path=file_in_hidden_path))
+    os_path = cm._get_os_path(model["path"])
+    cm.allow_hidden = False


when the "setup" was contained within the 'with' an exception is thrown when creating the file since allow_hidden is False. The fix was to allow hidden while creating the test file, and then disallow during the actual method test.

Wh1isper · 2023-11-13T03:56:13Z

jupyter_server/services/contents/handlers.py

+            self.set_status(HTTPStatus.NOT_FOUND)
+            self.write(f"file or directory {path!r} does not exist")
+            await self.finish()


It seems like it could be extracted into a function for clean error response like _finish_model: https://github.com/bloomsa/jupyter_server/blob/78394daec886b9b323b4801380569bd8ef966fc9/jupyter_server/services/contents/handlers.py#L86

I haven't figured out how to name this function yet though, FYI 😄

async def _finish_error(self, code, msg): self.set_status(code) self.write(msg) await self.finish()

good suggestion 👍

Wh1isper · 2023-11-13T04:01:47Z

jupyter_server/services/contents/handlers.py

-        self._finish_model(model, location=False)
+            validate_model(model, expect_content=content)
+            self._finish_model(model, location=False)
+        except web.HTTPError as exc:


I would suggest adding some comments here to explain why a web.HTTPError needs to be caught here, as it doesn't make any difference to the client

Mostly in #1328, we don't want a meaningless stack throw, which means that the situation here is fully under control.

blink1073

LGTM, thanks!

blink1073 · 2023-11-15T13:45:34Z

@Wh1isper, I'll wait for you to take another look.

Wh1isper · 2023-11-15T13:47:34Z

@blink1073 LGTM, thx

* ContentsHandler return 404 rather than raise exc (jupyter-server#1357) * Add more typings (jupyter-server#1356) * Publish 2.10.1 SHA256 hashes: jupyter_server-2.10.1-py3-none-any.whl: 20519e355d951fc5e1b6ac5952854fe7620d0cfb56588fa4efe362a758977ed3 jupyter_server-2.10.1.tar.gz: e6da2657a954a7879eed28cc08e0817b01ffd81d7eab8634660397b55f926472 * Bump to 2.11.0.dev0 * typo: ServerApp (jupyter-server#1361) * Support get file(notebook) md5 (jupyter-server#1363) * Update ruff and typings (jupyter-server#1365) * Update api docs with md5 param (jupyter-server#1364) * Publish 2.11.0 SHA256 hashes: jupyter_server-2.11.0-py3-none-any.whl: c9bd6e6d71dc5a2a25df167dc323422997f14682b008bfecb5d7920a55020ea7 jupyter_server-2.11.0.tar.gz: 78c97ec8049f9062f0151725bc8a1364dfed716646a66819095e0e8a24793eba * Bump to 2.12.0.dev0 * Change md5 to hash and hash_algorithm, fix incompatibility (jupyter-server#1367) Co-authored-by: Frédéric Collonval <fcollonval@gmail.com> * avoid unhandled error on some invalid paths (jupyter-server#1369) * Publish 2.11.1 SHA256 hashes: jupyter_server-2.11.1-py3-none-any.whl: 4b3a16e3ed16fd202588890f10b8ca589bd3e29405d128beb95935f059441373 jupyter_server-2.11.1.tar.gz: fe80bab96493acf5f7d6cd9a1575af8fbd253dc2591aa4d015131a1e03b5799a * Bump to 2.12.0.dev0 * Merge pull request from GHSA-h56g-gq9v-vc8r Co-authored-by: Steven Silvester <steven.silvester@ieee.org> * Publish 2.11.2 SHA256 hashes: jupyter_server-2.11.2-py3-none-any.whl: 0c548151b54bcb516ca466ec628f7f021545be137d01b5467877e87f6fff4374 jupyter_server-2.11.2.tar.gz: 0c99f9367b0f24141e527544522430176613f9249849be80504c6d2b955004bb * Bump to 2.12.0.dev0 * chore: update pre-commit hooks (jupyter-server#1370) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Steven Silvester <steven.silvester@ieee.org> * Update for tornado 6.4 (jupyter-server#1372) * Support async Authorizers (jupyter-server#1373) * Publish 2.12.0 SHA256 hashes: jupyter_server-2.12.0-py3-none-any.whl: 3482912efa4387bb1edc23ba60531796aff3b6d6a6e93a5810f5719e2bdb48b7 jupyter_server-2.12.0.tar.gz: 9fa74ed3bb931cf33f42b3d9046e2788328ec9e6dcc59d48aa3e0910a491e3e4 * Bump to 2.13.0.dev0 * log extension import time at debug level unless it's actually slow (jupyter-server#1375) * Add support for async Authorizers (part 2) (jupyter-server#1374) * Publish 2.12.1 SHA256 hashes: jupyter_server-2.12.1-py3-none-any.whl: fd030dd7be1ca572e4598203f718df6630c12bd28a599d7f1791c4d7938e1010 jupyter_server-2.12.1.tar.gz: dc77b7dcc5fc0547acba2b2844f01798008667201eea27c6319ff9257d700a6d --------- Co-authored-by: Sam Bloomquist <bloomquist.sam@gmail.com> Co-authored-by: Steven Silvester <steven.silvester@ieee.org> Co-authored-by: blink1073 <blink1073@users.noreply.github.com> Co-authored-by: IITII <ccmejx@gmail.com> Co-authored-by: Zhongsheng Ji <9573586@qq.com> Co-authored-by: Frédéric Collonval <fcollonval@gmail.com> Co-authored-by: Min RK <benjaminrk@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zachary Sailer <zsailer@apple.com> Co-authored-by: Zsailer <Zsailer@users.noreply.github.com>

* Create CODEOWNERS * ContentsHandler return 404 rather than raise exc (jupyter-server#1357) * Add more typings (jupyter-server#1356) * Publish 2.10.1 SHA256 hashes: jupyter_server-2.10.1-py3-none-any.whl: 20519e355d951fc5e1b6ac5952854fe7620d0cfb56588fa4efe362a758977ed3 jupyter_server-2.10.1.tar.gz: e6da2657a954a7879eed28cc08e0817b01ffd81d7eab8634660397b55f926472 * Bump to 2.11.0.dev0 * typo: ServerApp (jupyter-server#1361) * Support get file(notebook) md5 (jupyter-server#1363) * Update ruff and typings (jupyter-server#1365) * Update api docs with md5 param (jupyter-server#1364) * Publish 2.11.0 SHA256 hashes: jupyter_server-2.11.0-py3-none-any.whl: c9bd6e6d71dc5a2a25df167dc323422997f14682b008bfecb5d7920a55020ea7 jupyter_server-2.11.0.tar.gz: 78c97ec8049f9062f0151725bc8a1364dfed716646a66819095e0e8a24793eba * Bump to 2.12.0.dev0 * Change md5 to hash and hash_algorithm, fix incompatibility (jupyter-server#1367) Co-authored-by: Frédéric Collonval <fcollonval@gmail.com> * avoid unhandled error on some invalid paths (jupyter-server#1369) * Publish 2.11.1 SHA256 hashes: jupyter_server-2.11.1-py3-none-any.whl: 4b3a16e3ed16fd202588890f10b8ca589bd3e29405d128beb95935f059441373 jupyter_server-2.11.1.tar.gz: fe80bab96493acf5f7d6cd9a1575af8fbd253dc2591aa4d015131a1e03b5799a * Bump to 2.12.0.dev0 * Merge pull request from GHSA-h56g-gq9v-vc8r Co-authored-by: Steven Silvester <steven.silvester@ieee.org> * Publish 2.11.2 SHA256 hashes: jupyter_server-2.11.2-py3-none-any.whl: 0c548151b54bcb516ca466ec628f7f021545be137d01b5467877e87f6fff4374 jupyter_server-2.11.2.tar.gz: 0c99f9367b0f24141e527544522430176613f9249849be80504c6d2b955004bb * Bump to 2.12.0.dev0 * chore: update pre-commit hooks (jupyter-server#1370) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Steven Silvester <steven.silvester@ieee.org> * Update for tornado 6.4 (jupyter-server#1372) * Support async Authorizers (jupyter-server#1373) * Publish 2.12.0 SHA256 hashes: jupyter_server-2.12.0-py3-none-any.whl: 3482912efa4387bb1edc23ba60531796aff3b6d6a6e93a5810f5719e2bdb48b7 jupyter_server-2.12.0.tar.gz: 9fa74ed3bb931cf33f42b3d9046e2788328ec9e6dcc59d48aa3e0910a491e3e4 * Bump to 2.13.0.dev0 * log extension import time at debug level unless it's actually slow (jupyter-server#1375) * Add support for async Authorizers (part 2) (jupyter-server#1374) * Publish 2.12.1 SHA256 hashes: jupyter_server-2.12.1-py3-none-any.whl: fd030dd7be1ca572e4598203f718df6630c12bd28a599d7f1791c4d7938e1010 jupyter_server-2.12.1.tar.gz: dc77b7dcc5fc0547acba2b2844f01798008667201eea27c6319ff9257d700a6d * Bump to 2.13.0.dev0 * Use ruff docstring-code-format (jupyter-server#1377) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Enable htmlzip and epub on readthedocs (jupyter-server#1379) * Update pre-commit deps (jupyter-server#1380) * Fix a typo in error message (jupyter-server#1381) * Force legacy ws subprotocol when using gateway (jupyter-server#1311) Co-authored-by: Emmanuel Pignot <emmanuel.pignot@netapp.com> Co-authored-by: Zachary Sailer <zachsailer@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zachary Sailer <zsailer@apple.com> * Publish 2.12.2 SHA256 hashes: jupyter_server-2.12.2-py3-none-any.whl: abcfa33f98a959f908c8733aa2d9fa0101d26941cbd49b148f4cef4d3046fc61 jupyter_server-2.12.2.tar.gz: 5eae86be15224b5375cdec0c3542ce72ff20f7a25297a2a8166a250bb455a519 * Bump to 2.13.0.dev0 * Fix test param for pytest-xdist (jupyter-server#1382) * Simplify the jupytext downstream test (jupyter-server#1383) * Import User unconditionally (jupyter-server#1384) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Publish 2.12.3 SHA256 hashes: jupyter_server-2.12.3-py3-none-any.whl: 6f85310ea5e6068568a521f079fba99d8d17e4884dd1d602ab0f43b3115204a8 jupyter_server-2.12.3.tar.gz: a1d2d51e497b1a6256c48b6940b0dd49b2553981baf1690077c37792f1fa23a1 * Bump to 2.13.0.dev0 * Fix log arguments for gateway client error (jupyter-server#1385) * Publish 2.12.4 SHA256 hashes: jupyter_server-2.12.4-py3-none-any.whl: a125ae18a60de568f78f55c84dd58759901a18ef279abf0418ac220653ca1320 jupyter_server-2.12.4.tar.gz: 41f4a1e6b912cc24a7c6c694851b37d3d8412b180f43d72315fe422cb2b85cc2 * merge 2.12.4 from upstream * merge 2.12.4 from upstream --------- Co-authored-by: Lironavr1 <107797717+Lironavr1@users.noreply.github.com> Co-authored-by: Sam Bloomquist <bloomquist.sam@gmail.com> Co-authored-by: Steven Silvester <steven.silvester@ieee.org> Co-authored-by: blink1073 <blink1073@users.noreply.github.com> Co-authored-by: IITII <ccmejx@gmail.com> Co-authored-by: Zhongsheng Ji <9573586@qq.com> Co-authored-by: Frédéric Collonval <fcollonval@gmail.com> Co-authored-by: Min RK <benjaminrk@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zachary Sailer <zsailer@apple.com> Co-authored-by: Zsailer <Zsailer@users.noreply.github.com> Co-authored-by: Nicholas Bollweg <nick.bollweg@gmail.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> Co-authored-by: Manu <21658174+epignot@users.noreply.github.com> Co-authored-by: Emmanuel Pignot <emmanuel.pignot@netapp.com> Co-authored-by: Zachary Sailer <zachsailer@gmail.com> Co-authored-by: Gonzalo Tornaría <tornaria@gmail.com> Co-authored-by: Marc Wouts <marc.wouts@gmail.com> Co-authored-by: Yuvi Panda <yuvipanda@gmail.com>

* ContentsHandler return 404 rather than raise exc (jupyter-server#1357) * Add more typings (jupyter-server#1356) * Publish 2.10.1 SHA256 hashes: jupyter_server-2.10.1-py3-none-any.whl: 20519e355d951fc5e1b6ac5952854fe7620d0cfb56588fa4efe362a758977ed3 jupyter_server-2.10.1.tar.gz: e6da2657a954a7879eed28cc08e0817b01ffd81d7eab8634660397b55f926472 * Bump to 2.11.0.dev0 * typo: ServerApp (jupyter-server#1361) * Support get file(notebook) md5 (jupyter-server#1363) * Update ruff and typings (jupyter-server#1365) * Update api docs with md5 param (jupyter-server#1364) * Publish 2.11.0 SHA256 hashes: jupyter_server-2.11.0-py3-none-any.whl: c9bd6e6d71dc5a2a25df167dc323422997f14682b008bfecb5d7920a55020ea7 jupyter_server-2.11.0.tar.gz: 78c97ec8049f9062f0151725bc8a1364dfed716646a66819095e0e8a24793eba * Bump to 2.12.0.dev0 * Change md5 to hash and hash_algorithm, fix incompatibility (jupyter-server#1367) Co-authored-by: Frédéric Collonval <fcollonval@gmail.com> * avoid unhandled error on some invalid paths (jupyter-server#1369) * Publish 2.11.1 SHA256 hashes: jupyter_server-2.11.1-py3-none-any.whl: 4b3a16e3ed16fd202588890f10b8ca589bd3e29405d128beb95935f059441373 jupyter_server-2.11.1.tar.gz: fe80bab96493acf5f7d6cd9a1575af8fbd253dc2591aa4d015131a1e03b5799a * Bump to 2.12.0.dev0 * Merge pull request from GHSA-h56g-gq9v-vc8r Co-authored-by: Steven Silvester <steven.silvester@ieee.org> * Publish 2.11.2 SHA256 hashes: jupyter_server-2.11.2-py3-none-any.whl: 0c548151b54bcb516ca466ec628f7f021545be137d01b5467877e87f6fff4374 jupyter_server-2.11.2.tar.gz: 0c99f9367b0f24141e527544522430176613f9249849be80504c6d2b955004bb * Bump to 2.12.0.dev0 * chore: update pre-commit hooks (jupyter-server#1370) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Steven Silvester <steven.silvester@ieee.org> * Update for tornado 6.4 (jupyter-server#1372) * Support async Authorizers (jupyter-server#1373) * Publish 2.12.0 SHA256 hashes: jupyter_server-2.12.0-py3-none-any.whl: 3482912efa4387bb1edc23ba60531796aff3b6d6a6e93a5810f5719e2bdb48b7 jupyter_server-2.12.0.tar.gz: 9fa74ed3bb931cf33f42b3d9046e2788328ec9e6dcc59d48aa3e0910a491e3e4 * Bump to 2.13.0.dev0 * log extension import time at debug level unless it's actually slow (jupyter-server#1375) * Add support for async Authorizers (part 2) (jupyter-server#1374) * Publish 2.12.1 SHA256 hashes: jupyter_server-2.12.1-py3-none-any.whl: fd030dd7be1ca572e4598203f718df6630c12bd28a599d7f1791c4d7938e1010 jupyter_server-2.12.1.tar.gz: dc77b7dcc5fc0547acba2b2844f01798008667201eea27c6319ff9257d700a6d * Bump to 2.13.0.dev0 * Use ruff docstring-code-format (jupyter-server#1377) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Enable htmlzip and epub on readthedocs (jupyter-server#1379) * Update pre-commit deps (jupyter-server#1380) * Fix a typo in error message (jupyter-server#1381) * Force legacy ws subprotocol when using gateway (jupyter-server#1311) Co-authored-by: Emmanuel Pignot <emmanuel.pignot@netapp.com> Co-authored-by: Zachary Sailer <zachsailer@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zachary Sailer <zsailer@apple.com> * Publish 2.12.2 SHA256 hashes: jupyter_server-2.12.2-py3-none-any.whl: abcfa33f98a959f908c8733aa2d9fa0101d26941cbd49b148f4cef4d3046fc61 jupyter_server-2.12.2.tar.gz: 5eae86be15224b5375cdec0c3542ce72ff20f7a25297a2a8166a250bb455a519 * Bump to 2.13.0.dev0 * Fix test param for pytest-xdist (jupyter-server#1382) * Simplify the jupytext downstream test (jupyter-server#1383) * Import User unconditionally (jupyter-server#1384) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Publish 2.12.3 SHA256 hashes: jupyter_server-2.12.3-py3-none-any.whl: 6f85310ea5e6068568a521f079fba99d8d17e4884dd1d602ab0f43b3115204a8 jupyter_server-2.12.3.tar.gz: a1d2d51e497b1a6256c48b6940b0dd49b2553981baf1690077c37792f1fa23a1 * Bump to 2.13.0.dev0 * Fix log arguments for gateway client error (jupyter-server#1385) * Publish 2.12.4 SHA256 hashes: jupyter_server-2.12.4-py3-none-any.whl: a125ae18a60de568f78f55c84dd58759901a18ef279abf0418ac220653ca1320 jupyter_server-2.12.4.tar.gz: 41f4a1e6b912cc24a7c6c694851b37d3d8412b180f43d72315fe422cb2b85cc2 * Bump to 2.13.0.dev0 * Improve warning handling (jupyter-server#1386) * Publish 2.12.5 SHA256 hashes: jupyter_server-2.12.5-py3-none-any.whl: 184a0f82809a8522777cfb6b760ab6f4b1bb398664c5860a27cec696cb884923 jupyter_server-2.12.5.tar.gz: 0edb626c94baa22809be1323f9770cf1c00a952b17097592e40d03e6a3951689 * Bump to 2.13.0.dev0 * fix "Shutdown" -> "Shut down" (jupyter-server#1389) * chore: update pre-commit hooks (jupyter-server#1390) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * websockets: add configurations for ping interval and timeout (jupyter-server#1391) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Add deprecation note for `ServerApp.preferred_dir` (jupyter-server#1396) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Fix color in windows log console with colorama (jupyter-server#1397) * Replace _jupyter_server_extension_paths in apidocs (jupyter-server#1393) * Add an option to have authentication enabled for all endpoints by default (jupyter-server#1392) * Update release workflows (jupyter-server#1399) * Publish 2.13.0 SHA256 hashes: jupyter_server-2.13.0-py3-none-any.whl: 77b2b49c3831fbbfbdb5048cef4350d12946191f833a24e5f83e5f8f4803e97b jupyter_server-2.13.0.tar.gz: c80bfb049ea20053c3d9641c2add4848b38073bf79f1729cea1faed32fc1c78e * Bump to 2.14.0.dev0 * Pin to Pytest 7 (jupyter-server#1401) * Update pytest requirement from <8,>=7.0 to >=7.0,<9 (jupyter-server#1402) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Don't crash on invalid JSON in page_config (jupyter-server#1403) (jupyter-server#1404) * Ignore zero-length page_config.json, restore previous behavior of crashing for invalid JSON (jupyter-server#1405) * don't include token in dashboard link, when available (jupyter-server#1406) * chore: update pre-commit hooks (jupyter-server#1409) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Update simple extension README to cd into correct subdirectory (jupyter-server#1410) Co-authored-by: Mark Pizzutillo <pizmark@amazon.com> * Set all min deps (jupyter-server#1411) * Fix jupytext and lint CI failures (jupyter-server#1413) * docs: list server extensions (jupyter-server#1412) * Link to GitHub repo from the docs (jupyter-server#1415) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Publish 2.14.0 SHA256 hashes: jupyter_server-2.14.0-py3-none-any.whl: fb6be52c713e80e004fac34b35a0990d6d36ba06fd0a2b2ed82b899143a64210 jupyter_server-2.14.0.tar.gz: 659154cea512083434fd7c93b7fe0897af7a2fd0b9dd4749282b42eaac4ae677 * Bump to 2.15.0.dev0 * chore: update pre-commit hooks (jupyter-server#1421) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Steven Silvester <steven.silvester@ieee.org> * Removing excessive logging from reading local files (jupyter-server#1420) Co-authored-by: Kevin Bates <kbates4@gmail.com> * Use hatch fmt command (jupyter-server#1424) * Merge pull request from GHSA-hrw6-wg82-cm62 * filefind: avoid handling absolute paths we don't need or want absolute path support, which we inherited from generic ipython_genutils only supporting relative paths lets us avoid attempting to accessing files we know we won't accept * Apply suggestions from code review Co-authored-by: M Bussonnier <bussonniermatthias@gmail.com> * filefind: only accept Sequence[str] we only call it one place, might as well be simple about it * version_info gate for is_relative_to * clarify docstring Co-authored-by: Carol Willing <carolcode@willingconsulting.com> --------- Co-authored-by: M Bussonnier <bussonniermatthias@gmail.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com> * Publish 2.14.1 SHA256 hashes: jupyter_server-2.14.1-py3-none-any.whl: 16f7177c3a4ea8fe37784e2d31271981a812f0b2874af17339031dc3510cc2a5 jupyter_server-2.14.1.tar.gz: 12558d158ec7a0653bf96cc272bc7ad79e0127d503b982ed144399346694f726 * Bump to 2.15.0.dev0 * Update simple extension examples: _jupyter_server_extension_points (jupyter-server#1426) * chore: update pre-commit hooks (jupyter-server#1427) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Steven Silvester <steven.silvester@ieee.org> * Add Changelog for 2.14.1 (jupyter-server#1430) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore: update pre-commit hooks (jupyter-server#1441) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Steven Silvester <steve.silvester@mongodb.com> * Update documentation for `cookie_secret` (jupyter-server#1433) * Do not log environment variables passed to kernels (jupyter-server#1437) * Pass session_id during Websocket connect (jupyter-server#1440) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Publish 2.14.2 SHA256 hashes: jupyter_server-2.14.2-py3-none-any.whl: 47ff506127c2f7851a17bf4713434208fc490955d0e8632e95014a9a9afbeefd jupyter_server-2.14.2.tar.gz: 66095021aa9638ced276c248b1d81862e4c50f292d575920bbe960de1c56b12b --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Sam Bloomquist <bloomquist.sam@gmail.com> Co-authored-by: Steven Silvester <steven.silvester@ieee.org> Co-authored-by: blink1073 <blink1073@users.noreply.github.com> Co-authored-by: IITII <ccmejx@gmail.com> Co-authored-by: Zhongsheng Ji <9573586@qq.com> Co-authored-by: Frédéric Collonval <fcollonval@gmail.com> Co-authored-by: Min RK <benjaminrk@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Zachary Sailer <zsailer@apple.com> Co-authored-by: Zsailer <Zsailer@users.noreply.github.com> Co-authored-by: Nicholas Bollweg <nick.bollweg@gmail.com> Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com> Co-authored-by: Manu <21658174+epignot@users.noreply.github.com> Co-authored-by: Emmanuel Pignot <emmanuel.pignot@netapp.com> Co-authored-by: Zachary Sailer <zachsailer@gmail.com> Co-authored-by: Gonzalo Tornaría <tornaria@gmail.com> Co-authored-by: Marc Wouts <marc.wouts@gmail.com> Co-authored-by: Yuvi Panda <yuvipanda@gmail.com> Co-authored-by: Alex Meiburg <timeroot.alex@gmail.com> Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk> Co-authored-by: hansepac <131813389+hansepac@users.noreply.github.com> Co-authored-by: Simon Li <orpheus+devel@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Burt Holzman <burt@fnal.gov> Co-authored-by: Mark <markypizz@gmail.com> Co-authored-by: Mark Pizzutillo <pizmark@amazon.com> Co-authored-by: Luciano Resende <lresende@apple.com> Co-authored-by: Kevin Bates <kbates4@gmail.com> Co-authored-by: M Bussonnier <bussonniermatthias@gmail.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com> Co-authored-by: Steven Silvester <steve.silvester@mongodb.com> Co-authored-by: Gonzalo Gasca Meza <gogasca@google.com>

contents handler 404 rather than raise exc

252e8a2

blink1073 added the bug label Nov 8, 2023

test case for file not found

3d5cb0a

Merge branch 'main' into main

93a7666

bloomsa added 2 commits November 12, 2023 19:06

fix test_manager::test_404 logic

33f55b5

Merge remote-tracking branch 'origin/main'

78394da

bloomsa commented Nov 13, 2023

View reviewed changes

Wh1isper reviewed Nov 13, 2023

View reviewed changes

Wh1isper approved these changes Nov 13, 2023

View reviewed changes

add _finish_error method and code comment

dedb393

blink1073 approved these changes Nov 15, 2023

View reviewed changes

Wh1isper approved these changes Nov 15, 2023

View reviewed changes

blink1073 merged commit a20fe64 into jupyter-server:main Nov 15, 2023
35 checks passed

bloomsa mentioned this pull request Dec 3, 2023

Don't let ContentsHandler's internal 404 bubble up. #1328

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ContentsHandler return 404 rather than raise exc #1357

ContentsHandler return 404 rather than raise exc #1357

bloomsa commented Nov 8, 2023

bloomsa commented Nov 8, 2023

blink1073 commented Nov 8, 2023

blink1073 commented Nov 8, 2023

bloomsa commented Nov 10, 2023

blink1073 commented Nov 10, 2023

bloomsa commented Nov 12, 2023

blink1073 commented Nov 12, 2023

bloomsa Nov 13, 2023

Wh1isper Nov 13, 2023

bloomsa Nov 15, 2023

Wh1isper Nov 13, 2023

blink1073 left a comment

blink1073 commented Nov 15, 2023

Wh1isper commented Nov 15, 2023

ContentsHandler return 404 rather than raise exc #1357

ContentsHandler return 404 rather than raise exc #1357

Conversation

bloomsa commented Nov 8, 2023

bloomsa commented Nov 8, 2023

blink1073 commented Nov 8, 2023

blink1073 commented Nov 8, 2023

bloomsa commented Nov 10, 2023

blink1073 commented Nov 10, 2023

bloomsa commented Nov 12, 2023

blink1073 commented Nov 12, 2023

bloomsa Nov 13, 2023

Choose a reason for hiding this comment

Wh1isper Nov 13, 2023

Choose a reason for hiding this comment

bloomsa Nov 15, 2023

Choose a reason for hiding this comment

Wh1isper Nov 13, 2023

Choose a reason for hiding this comment

blink1073 left a comment

Choose a reason for hiding this comment

blink1073 commented Nov 15, 2023

Wh1isper commented Nov 15, 2023