Parameterized kernel specs #1431
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2024
for more information, see https://pre-commit.ci
…liusar/jupyter_server into parametrizing_kernels
for more information, see https://pre-commit.ci
…liusar/jupyter_server into parametrizing_kernels
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
fm2022aa
reviewed
Jul 25, 2024
jupyter_server/serverapp.py
Outdated
| @@ -3025,6 +3039,12 @@ def start_app(self) -> None: | |||
| # Handle the browser opening. | |||
| if self.open_browser and not self.sock: | |||
| self.launch_browser() | |||
| if self.allow_insecure_kernelspec_params: | |||
| print("yesssssssssssssssss") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This work is in progress as JEP jupyter/enhancement-proposals#87.
This PR should be reviewed when the JEP has been accepted
Code changes
This PR includes support of
custom_kernel_specsvariable that is used to setup custom kernel specs before running a kernel.This
custom_kernel_specsincludes kernel parameters which a user has selected from a kernel dialog on JupyterLabHow to use
Parameterized kernel specs jupyterlab/jupyterlab#16487
Parameterized kernel specs jupyter/jupyter_client#1028
Add allow_insecure_kernelspec_params to page config jupyterlab/jupyterlab_server#460