Better error message when starting kernel for session. #1478
+38
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1186 then? |
krassowski
reviewed
Dec 17, 2024
| @@ -161,6 +161,8 @@ async def patch(self, session_id): | |||
| changes["kernel_id"] = kernel_id | |||
| elif model["kernel"].get("name") is not None: | |||
| kernel_name = model["kernel"]["name"] | |||
|
|
|||
| try: | |||
| kernel_id = await sm.start_kernel_for_session( | |||
| session_id, | |||
| kernel_name=kernel_name, | |||
There was a problem hiding this comment.
Some of the test failures are relavant:
File "D:\a\jupyter_server\jupyter_server\jupyter_server\services\sessions\handlers.py", line 168, in patch
kernel_name=kernel_name,
UnboundLocalError: local variable 'kernel_name' referenced before assignment
I think the try: needs one more indentation level
There was a problem hiding this comment.
Oh sorry, yes. I'm tired today.
This catches error when starting a kernel for a session (for example if one switches the kernel for an existing notebook), and propagate the error. Otherwise the frontend will just show "Error: uncaught exception". In addition this setup ruff G001 – do not use string formatting in logging, see some of the reasons to not do that: https://docs.astral.sh/ruff/rules/logging-string-format/ And fixes the few instances where jupyter-server does it.
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Carreau
force-pushed
the
catch-session-change
branch
from
63e7c42 to
5266697
Compare
Co-authored-by: David Brochart <david.brochart@gmail.com>
|
I published a new version of jupyter-events, retriggering CI. |
only part of it. that would be solved by enabling G002 |
|
Working on #1481 to fix the unrelated errors. |
|
Awesome ! Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This catches error when starting a kernel for a session (for example if one switches the kernel for an existing notebook), and propagate the error. Otherwise the frontend will just show "Error: uncaught exception".
In addition this setup ruff G001 – do not use string formatting in logging, see some of the reasons to not do that:
https://docs.astral.sh/ruff/rules/logging-string-format/
And fixes the few instances where jupyter-server does it.