-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ExtensionHandler a Mixin #174
Make ExtensionHandler a Mixin #174
Conversation
@Zsailer @kevin-bates As discussed during the jupyter server meeting, another option is making the ExtensionHandler a Mixin. I will give it a try in this PR. |
I think it's more appropriate to make Unfortunately, this is a backwards-incompatible change from 0.2.x. I think we need to backport this to 0.2.x, because this could cause issues for us later if other projects depend on 0.2.x first and then switch to 0.3.x. |
@Zsailer Are you saying that ExtensionHandlerMixin should extend |
a488306
to
4601830
Compare
@Zsailer @kevin-bates I have renamed that PR from This works well so far for the main LabHandler and I will further work on the tests for the other handlers like WorkspacesHandler and SettingsHandler. Please note the construct I use now and which is subject to discussion/update: |
This is looking great, @echarles!
This is exactly what I had in mind. 😎 It does make the inheritance list a little long, but I think it's the most readable, transparent, and Pythonic form. |
@Zsailer I have progressed on the jupyterlab-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @echarles! Any reason not to merge this?
…n_handlers Make ExtensionHandler a Mixin
This is a first dry attempt to support extension handlers needed by JupyterLab jupyterlab/jupyterlab_server#79
The corresponding issue is #173
This current changes allow make the jlab extensions operational, but this implementation is suboptimal as it duplicates code (with minor changes) from the base package.