Telemetry and Event Logging #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump telemetry extension commit as well
Experiments here informed the schema naming recommendations in jupyter/telemetry#11
python 3.5 is still supported
This lets us add detailed documentation & description to our schemas, which is very hard to do in JSON. We also add a lot of documentation to the one JSON schema we have
Primary advantage over JSON is that we can do multi-line strings for more detailed documentation. We also expect humans to read & write these, so YAML is a much better format there. All JSON is also valid YAML, so that helps. Depends on jupyter/telemetry#13
We made a v0.0.1 release!
|
Going to dive into this |
Zsailer
commented
May 22, 2020
|
|
||
| from tornado import web | ||
|
|
||
| from notebook.utils import url_path_join |
There was a problem hiding this comment.
update to jupyter_server
|
@Zsailer any updates? |
|
Closing in favor of #352. |
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of jupyter/notebook#4752.
This is an initial draft of telemetry/eventlogging in the Jupyter Server. This was inspired by #231 from @gclen. For now, this PR adds structured event logging to "contents" API, but we could easily draft event schemas for the kernels API after this lands.
Concurrently, I've drafted a large PR in the telemetry repo, jupyter/telemetry#46, for handling personal data. A major block for landing telemetry in jupyter_server has been the concern around the logging of personal data. Before we can merge something here, we need to have a sound story around how PII is should be handled.
I will try to flesh out the details further in this PR when I have more time. In the meantime, I thought I'd leave this here for others to take a look at. (Thank you, @yuvipanda, for the initial draft of this PR!).