-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: reviews for release 1.0.0 #299
Merged
kevin-bates
merged 2 commits into
jupyter-server:master
from
datalayer-externals:docs-1.0.0-review
Sep 18, 2020
Merged
docs: reviews for release 1.0.0 #299
kevin-bates
merged 2 commits into
jupyter-server:master
from
datalayer-externals:docs-1.0.0-review
Sep 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
reviewed
Sep 3, 2020
Zsailer
reviewed
Sep 3, 2020
Zsailer
reviewed
Sep 3, 2020
Zsailer
reviewed
Sep 3, 2020
Zsailer
reviewed
Sep 3, 2020
blink1073
reviewed
Sep 3, 2020
kevin-bates
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thank you Eric!
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
….0-review docs: reviews for release 1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #288
A few broken links, better links, minor rephrasing, and overall the addition of some more details in the security page that was dropped from notebook, but that is still. worth having here (trusted notebooks...) as we provide notebook related features anyway... (kernels...).