Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtensionHandler logger fallback to default logger #302

Merged
merged 1 commit into from
Sep 3, 2020
Merged

ExtensionHandler logger fallback to default logger #302

merged 1 commit into from
Sep 3, 2020

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Sep 3, 2020

Some extra cleanup in the extension API.

  • Make extension handlers use default tornado logger if no logger is found.
  • Provide fallback to jupyter_server templates if extension doesn't have a given template.

@blink1073 blink1073 merged commit 068f950 into jupyter-server:master Sep 3, 2020
@blink1073
Copy link
Contributor

Released as jupyter_server-1.0.0rc14

@Zsailer Zsailer mentioned this pull request Sep 4, 2020
Closed
@blink1073 blink1073 added this to the 1.0 Release milestone Sep 17, 2020
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
@sathishlxg
Resolve static file to full path using the baseUrl (jupyter-server#302)
7520575
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
@blink1073
Merge pull request jupyter-server#302 from Zsailer/cleanup
363f3ea 
ExtensionHandler logger fallback to default logger
@Zsailer Zsailer deleted the cleanup branch January 16, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@Zsailer @blink1073