Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow toggling auth for prometheus metrics #344

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Allow toggling auth for prometheus metrics #344

merged 1 commit into from
Dec 1, 2020

Conversation

yuvipanda
Copy link
Contributor

Equivalent to jupyterhub/jupyterhub#2224.

Port of jupyter/notebook#5870

Prometheus metrics can potentially leak information about
the user, so they should be kept behind auth by default.
However, for many JupyterHub deployments, they would need
to be scraped by a centralized Prometheus instance that can not
really authenticate separately to each user notebook without
a lot of work. Admins can use this setting to allow unauthenticated
access to the /metrics endpoint.

Equivalent to jupyterhub/jupyterhub#2224.

Port of jupyter/notebook#5870

Prometheus metrics can potentially leak information about
the user, so they should be kept behind auth by default.
However, for many JupyterHub deployments, they would need
to be scraped by a centralized Prometheus instance that can not
really authenticate separately to each user notebook without
a lot of work. Admins can use this setting to allow unauthenticated
access to the /metrics endpoint.
@Zsailer
Copy link
Member

Zsailer commented Dec 1, 2020

Thanks, @yuvipanda.

@Zsailer Zsailer merged commit c45d7f3 into jupyter-server:master Dec 1, 2020
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Allow toggling auth for prometheus metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants